Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m43vv-0006xf-Kd for pgsql-bugs@arkaria.postgresql.org; Thu, 15 Jul 2021 16:09:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m43vu-0004Wb-9Z for pgsql-bugs@arkaria.postgresql.org; Thu, 15 Jul 2021 16:09:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m43vu-0004WT-2g for pgsql-bugs@lists.postgresql.org; Thu, 15 Jul 2021 16:09:54 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m43vr-0006xU-GD for pgsql-bugs@lists.postgresql.org; Thu, 15 Jul 2021 16:09:53 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 18FA83200923; Thu, 15 Jul 2021 12:09:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 15 Jul 2021 12:09:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=R9ZXXij2oCNcFzdx2itmrGPjGT3Pu8nvc6yjZ8SGbz8=; b=Yr9rIh8r lC++1X+RkG9xfoFXLPpJlu7Wm8HegEc8cjX54x+tu5otk+dSVy30t8UBm0x6Isal BB26WW1nWGzEnrmbIG/whP01Itf8B7aNOJjrG3XUv3vkdkIFtn+wJsju29C7ho/S mu6vNjk9H3TmbUT+hghkKVk/kry6S5vhIslmLun+0f1QrtVeGbRWkN4gdOAOTsfb Pzc6aY1aIcfR/rdDQpWjmn6fF1w6F0efP6mqlqG5Kca5r/03B7sXjv36b2wLbHrG KdTIZZqimwBfQCOrRxgUk0B/4Lujf1Ad8QJ0Z8X9N3qpjsjMmA6SHq0xP8oNr/eZ 680LD3JaJ8chPA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddtgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenog fuuhhsphgvtghtffhomhgrihhnucdlgeelmdenucfjughrpeffhffvuffkgggtugfgjges thekredttddtjeenucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvg hrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnheptddvvedv feekffduvdffvdfhffdtveektdehudeileefhfeiudeggeeugfduueeunecuffhomhgrih hnpegvnhhtvghrphhrihhsvggusgdrtghomhdpghhoohhglhgvrdgtohhmnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvse grlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Jul 2021 12:09:48 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 36A7B2A099B; Thu, 15 Jul 2021 12:09:45 -0400 (-04) Date: Thu, 15 Jul 2021 12:09:45 -0400 From: Alvaro Herrera To: Marcin Krupowicz Cc: Kyotaro Horiguchi , jeff.janes@gmail.com, mk@071.ovh, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size Message-ID: <202107151609.wx3mso7tpayc@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Jul-15, Marcin Krupowicz wrote: > On Thu, 15 Jul 2021 at 08:33, Kyotaro Horiguchi wrote: > > This is it. It is for the master branch but also applicable to 14 as > > is. Not needed for earlier version. > > I believe the test works for Windows but haven't checked. Oh my, what an oversight. Thanks Kyotaro for the investigation and fix; I'll get it pushed today. > Thanks for that. To clarify - is it not going to be fixed in 13.x? It definitely is, since the feature is there. I'll fix the apply conflicts, since they're pretty trivial. (No need to send a new patch.) -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Ed is the standard text editor." http://groups.google.com/group/alt.religion.emacs/msg/8d94ddab6a9b0ad3