Date: Thu, 15 Jul 2021 17:33:20 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: jeff.janes@gmail.com, mk@071.ovh, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17103: WAL segments are not removed after exceeding
 max_slot_wal_keep_size
Message-ID: <202107152133.dekh4keh4r44@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ndzm6eckd6a334dr"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202107152049.3kftantyynji@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202107152133.dekh4keh4r44%40alvherre.pgsql>
Precedence: bulk


--ndzm6eckd6a334dr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2021-Jul-15, Alvaro Herrera wrote:

> Actually, looking again, isn't this supposed to happen in KeepLogSeg()?
> We have a block that caps to max_slot_wal_keep_size_mb there ... why did
> that not work?

I find that this smaller patch is sufficient to make the added test case
work.  However, I'm not sure I understand *why* ...

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/

--ndzm6eckd6a334dr
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v5-0001-Advance-old-segment-horizon-properly-after-slot-i.patch"