Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m73gm-0007Af-M4 for pgsql-bugs@arkaria.postgresql.org; Fri, 23 Jul 2021 22:30:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m73gl-00018E-0t for pgsql-bugs@arkaria.postgresql.org; Fri, 23 Jul 2021 22:30:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m73gk-000186-JR for pgsql-bugs@lists.postgresql.org; Fri, 23 Jul 2021 22:30:38 +0000 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m73gh-0006qd-G8 for pgsql-bugs@lists.postgresql.org; Fri, 23 Jul 2021 22:30:37 +0000 Received: by mail-io1-xd35.google.com with SMTP id r18so4347791iot.4 for ; Fri, 23 Jul 2021 15:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4Lud6KHBds1qxWIOTNRQDTVq99fIHMAnib8c9PRvV40=; b=btnF5/Mq5YlmCnl2VLSAiG6ppmqwKWkjtfo8i7P9YAlzxm7lK9OTpIsJS2Z/AOwtQw Me6w0ZANs4aaSYvZcxSMUOMkzy48kMomV4V+NekXgdY15KM2nrBenF2i7p1G+Fwd5zr5 gMpTooDtB/0oiNI7ICtsaAQ9Zu+CWuQIdeJjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4Lud6KHBds1qxWIOTNRQDTVq99fIHMAnib8c9PRvV40=; b=TTFIVsvYgDqFO9XUfnJsdsKZ31iRQuzGw+CE04VTno7tRFuuWq+Jh2zNWdj4MkRMfc u4UBhJlaHDjznqFsvuWgjD/d7JdZVORTkDCC0jsGCdp6Um7w34a4hkThPOgFSeunZhk3 2wtB1Gh89lbiWI1BU+sMGvePVJoz7Jyb8933rcZ09BsZVnzuD/9UwZG+68N1pBRAC+HM Acev/KggGYkj99LnPZIWnWSSRZm+mXAHvJvF5G7P62KP+uasNYdksBxLIGrylafFu6Dt utiX9sG9CZYrdyKtv30b9uSGyFJC0Jt9qfcpM21GWqtjVgIqFZbGd5lyUHBEbxzNRwjV +zRw== X-Gm-Message-State: AOAM532RiC61hlR1DoKXXrFGdlKQHArETBaa1jteepbbm6qTAzcGXGk8 pnAhSgn6Jd/pJdujic3dnxoJqKh89Gf5DQ== X-Google-Smtp-Source: ABdhPJzkd/jd7tpuD071mCmFqYGgV0R4OZtOS4mAZp3B6b7PhRBOr9poqsByw5RXe4q69SS8Pk9f7A== X-Received: by 2002:a02:b199:: with SMTP id t25mr5828812jah.35.1627079432957; Fri, 23 Jul 2021 15:30:32 -0700 (PDT) Received: from gust.leadboat.com ([172.243.183.102]) by smtp.gmail.com with ESMTPSA id l18sm17145114ioc.13.2021.07.23.15.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 15:30:32 -0700 (PDT) Date: Fri, 23 Jul 2021 18:30:21 -0400 From: Noah Misch To: Andrey Borodin Cc: Michael Paquier , Tom Lane , pgsql-bugs@lists.postgresql.org Subject: Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data Message-ID: <20210723223021.GA1354601@gust.leadboat.com> References: <20210719181005.GB972361@gust.leadboat.com> <1727EC55-0709-4E06-91C9-212682A134C7@yandex-team.ru> <20210720214936.GA1040253@gust.leadboat.com> <20210721175530.GA1090577@gust.leadboat.com> <946242CB-D63A-4D7B-A5A5-485165F5B78A@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <946242CB-D63A-4D7B-A5A5-485165F5B78A@yandex-team.ru> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Jul 23, 2021 at 09:33:18PM +0500, Andrey Borodin wrote: > > 21 июля 2021 г., в 22:55, Noah Misch написал(а): > > These drafts use reasonable concepts. Would you develop them into a > > ready-to-commit patch? You may be able to translate your probabilistic test > > procedures from https://gist.github.com/x4m/8b6025995eedf29bf588727375014dfc > > into something like the src/bin/pgbench/t/001_pgbench_with_server.pl test of > > pg_enum_oid_index. > > I'm working on it. Is it OK to use amcheck in pgbench tests? Or is it better to add the test to amcheck? It could be okay, but I think it's better to add the test under amcheck. You could still use pgbench in the test.