Date: Sun, 28 Nov 2021 23:01:22 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Dmitry Koval <d.koval@postgrespro.ru>,
	Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17288: PSQL bug with COPY command (Windows)
Message-ID: <20211129050122.GK17618@telsasoft.com>
References: 
 <CAC+AXB1C1C_z3XQR=ZxiG+V0U9RDJFtJJamvYMoq+d4RoVRh4A@mail.gmail.com>
 <9caa0612-19e5-f860-4b97-908a1c721233@postgrespro.ru>
 <CAC+AXB1FTZueNdvT1F4fpr4z9gxpcKkgWa-Awor9XC9PAKLVSA@mail.gmail.com>
 <YZiGIxk5F3TT/OJc@paquier.xyz>
 <ff540eb5-3493-cf02-6c22-20ef6e15fee9@postgrespro.ru>
 <CAC+AXB2GfM3NGjx7vc+=UvbD_bzQheiPqk2BQiFRn7G0oVUDhA@mail.gmail.com>
 <c97531c7-a439-78b5-33e6-6aab5a900949@postgrespro.ru>
 <YZ3Cm7PKGesAitYN@paquier.xyz>
 <b108ffee-53b7-f11d-4110-1c2a72fa63b2@postgrespro.ru>
 <YZ8BvVysOLJcTP16@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YZ8BvVysOLJcTP16@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211129050122.GK17618%40telsasoft.com>
Precedence: bulk

On Thu, Nov 25, 2021 at 12:23:41PM +0900, Michael Paquier wrote:
> On Wed, Nov 24, 2021 at 10:44:09AM +0300, Dmitry Koval wrote:
> > Unfortunately, you are.
> > All my COPY-tests work well with files.
> > I see a problem in the terminal only ...
> 
> While checking all the callers of fstat() in the core code, I have
> discovered that this broke a second case when stdout is not
> redirected: pg_recvlogical -f -.  In this case, the code would just
> bump on EINVAL repeatedly instead of crashing, but equally broken it
> was.  There is a TAP test for this case in src/bin/pg_basebackup/, but
> it would not trigger the problem per the redirection already done
> there.
> 
> Anyway, I have run more tests, tweaked slightly the comment, and
> applied it down to 14.  Thanks to both of you!

Do you know this causes a new warning ?

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2021-11-29%2004%3A00%3A29

Nov 28 23:06:41 c:/mingw/msys/1.0/home/pgrunner/bf/root/HEAD/pgsql.build/../pgsql/src/port/win32stat.c:309:3: warning: implicit declaration of function 'GetFinalPathNameByHandleA'; did you mean 'GetFullPathNameA'? [-Wimplicit-function-declaration]
...

-- 
Justin