Date: Wed, 2 Feb 2022 11:42:02 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17355: Server crashes on ExecReScanForeignScan in
 postgres_fdw when accessing foreign partition
Message-ID: <202202021442.hsxbhre2k533@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAPmGK166WGTskmduTR+N7enYDUGrtvmVLZPn0ak_gk3gcYTaCQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202202021442.hsxbhre2k533%40alvherre.pgsql>
Precedence: bulk

On 2022-Feb-01, Etsuro Fujita wrote:

> I didn’t include your test because in my
> understanding we don’t add such a test into the postgres_fdw
> regression test.  I’ll commit the patch if there are no objections
> from you (or anyone else).

I think it would be good to reconsider this.  We currently don't have
any isolation test files for postgres_fdw, but that doesn't mean we
can't add some (we now have several subdirs where both types of tests
coexist).  And if we don't have these tests, it will be easier to break
this again in the future without noticing if we decide to rework
executor code again, which I'm sure we'll do.

Maybe you don't need to add the test in back-branches, which is more
work; but if you only target branch master, it should only require an
ISOLATION line in the Makefile listing the new test.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Every machine is a smoke machine if you operate it wrong enough."
https://twitter.com/libseybieda/status/1541673325781196801