Date: Thu, 10 Feb 2022 17:54:55 -0800
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>,
	Thomas Munro <thomas.munro@gmail.com>, byavuz81@gmail.com,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
	Heikki Linnakangas <heikki.linnakangas@iki.fi>,
	Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17391: While using --with-ssl=openssl and
 PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
Message-ID: <20220211015455.mkl6cvstttp5zfco@alap3.anarazel.de>
References: <C44CE9FB-B37E-47D3-924B-4AF808AE98B1@yesql.se>
 <887CBA28-0942-4084-BE09-FBE0D6A1DB53@yesql.se>
 <621771.1644098845@sss.pgh.pa.us>
 <635760.1644108785@sss.pgh.pa.us>
 <1113966.1644280235@sss.pgh.pa.us>
 <C112C400-2CB5-4DCA-A699-00DC0333B665@yesql.se>
 <1537890.1644462214@sss.pgh.pa.us>
 <1952254.1644540297@sss.pgh.pa.us>
 <20220211011025.ek7exh6owpzjyudn@alap3.anarazel.de>
 <1955929.1644542728@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1955929.1644542728@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20220211015455.mkl6cvstttp5zfco%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-02-10 20:25:28 -0500, Tom Lane wrote:
> I was staring at that for awhile too.  It's my own code (from 1f39a1c0641)
> but it sure confuses me now; at the very least the code is not in sync
> with the comment.  However, it's been that way for a couple years now and
> we've not had complaints suggesting it's broken, so maybe it's the comment
> that's wrong.

I wonder if it could be part of the whole "walreceiver on windows not noticing
connection death" business. Libpq internally gets a write failure, defers
reporting it, we end up in libpqrcv_PQgetResult(), which will call PQisBusy()
returning true due to write_failure, which then causes us to wait for incoming
socket IO. But WaitEventForMultipleObjects() will not be signalled again due
to the the edge triggered nature of FD_CLOSE.

Greetings,

Andres Freund