Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noAPZ-00062q-9n for pgsql-bugs@arkaria.postgresql.org; Mon, 09 May 2022 20:55:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1noAPY-0003jS-0F for pgsql-bugs@arkaria.postgresql.org; Mon, 09 May 2022 20:55:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noAPX-0003jE-3o for pgsql-bugs@lists.postgresql.org; Mon, 09 May 2022 20:55:19 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1noAPQ-000440-9m for pgsql-bugs@lists.postgresql.org; Mon, 09 May 2022 20:55:18 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E18383200AED; Mon, 9 May 2022 16:55:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 09 May 2022 16:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1652129709; x=1652216109; bh=qQ11J1btSM7ZUD50lm8tr8cC7O4B 5smrmbpRq7qLVwM=; b=lbREBwMnOFYVPLrxaUKrMcqFsPevvTNUrbBnHQfDzsoM nRRJgQa3CSuRZJuSsdKCfmT5yjADNPlNxO5b5S/xa2sinEUoXcnOLDJlsaYadQLm fp6g6zbd7RcEXrZcdesRIOyt9UbWvRRPSiXhlr+XwvQ+h6P0Z+bf485uF+r2ofYg G1iXACb3PQjVFG/k+4vzcAiB/EW+RRaGE5dJQowU600h6a6T7a8tgQOrymfkaiTD Ca2hYlUHV1tKXnzKqvUldjhyYsSbOlrNBBvhN9F2QeZi6IseSVmg03PPl3QqqFwF Cghjme1zx+StNdH9OZdZYLaXgbJPRp+8CUZqTwGFdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeelgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne goufhushhpvggtthffohhmrghinhculdegledmnecujfgurhepfffhvfevuffkgggtugfg jgesthekredttddtjeenucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvh hhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepheek leeihfetffdtkeefvdeiudekudekhedvgeeitdduffffleelkedtieegvddvnecuffhomh grihhnpegvnhhtvghrphhrihhsvggusgdrtghomhdpghhoohhglhgvrdgtohhmnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrh gvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 May 2022 16:55:08 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 387AE2A09A6; Mon, 9 May 2022 22:55:06 +0200 (CEST) Date: Mon, 9 May 2022 22:55:06 +0200 From: Alvaro Herrera To: Tom Lane Cc: Masahiko Sawada , krking@zju.edu.cn, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17477: A crash bug in transformValuesClause() Message-ID: <202205092055.n227skur4e3a@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3809468.1652109938@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Looking at the code, I understand that what your patch is doing is making the zeroth case no longer a special one but rather handled it in the same loop block as the other cases, which is why the bug is fixed. LGTM. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Ed is the standard text editor." http://groups.google.com/group/alt.religion.emacs/msg/8d94ddab6a9b0ad3