Feedback-ID: ia2694551:Fastmail
Date: Fri, 20 May 2022 17:23:19 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Amit Kapila <amit.kapila16@gmail.com>,
	LEMAIRE Leslie =?utf-8?Q?=28Charg=C3=A9e_de_mission?=
	=?utf-8?Q?=29?= - SG/SNUM/UNI/DRC
 <leslie.lemaire@developpement-durable.gouv.fr>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: Implicitly created operator family not listed by
 pg_event_trigger_ddl_commands
Message-ID: <202205201523.7m5jbfvyanmj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="kceutoikrbr7dfaw"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202205201412.jrrbxaotej3z@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202205201523.7m5jbfvyanmj%40alvherre.pgsql>
Precedence: bulk


--kceutoikrbr7dfaw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2022-May-20, Alvaro Herrera wrote:

> On 2022-May-20, Masahiko Sawada wrote:
> 
> > I think that the event trigger that emits these NOTICE messages
> > doesn't exist in 13 or older branches. It was added by 2d689babe3c.
> 
> Oh, hahah.  Hmm, I feel inclined to add the trigger rather than remove
> the lines from the expected output.

So I'm inclined to add the attached patch before the bugfix, in branches
10-13.  It simply adds the new event trigger to the existing test case,
being careful not to trip on the error message that it would generate
otherwise, for a bug that was only fixed in 14.

The other option, of course, is to not backpatch any of this earlier
than 14.  But the OP says she was experimenting with version 10
initially.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming"  (A. Stepanov)

--kceutoikrbr7dfaw
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-add-regression-tests-by-2d689babe3cb.patch"