Feedback-ID: ia2694551:Fastmail
Date: Tue, 24 May 2022 11:02:12 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Michael Paquier <michael@paquier.xyz>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	=?utf-8?B?0J/QtdGC0YrRgCDQodC70LDQstC+0LI=?= <pet.slavov@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17485: Records missing from Primary Key index when doing
 REINDEX INDEX CONCURRENTLY
Message-ID: <202205240902.bhkvu4lgljn3@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAH2-Wz=eJnkcLpgDhHzU=vz5Fu58HJxJB_Gt094Mx_L+6rD3_A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202205240902.bhkvu4lgljn3%40alvherre.pgsql>
Precedence: bulk

On 2022-May-23, Peter Geoghegan wrote:

> You seem to be addressing this PROC_IN_SAFE_IC snippet as if Andrey
> formally proposed it as a bugfix, which seems like an odd
> interpretation to me. It seems pretty clear to me that Andrey was just
> making an observation, in case it helped with debugging.

Right.

I approached it yesterday by running the test case with each
set_indexsafe_procflags() callsite commented out, see which one breaks
things.  Didn't reach any conclusion because I ran into thermal problems
with my laptop, which got me angry and couldn't make any further
progress.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"I'm always right, but sometimes I'm more right than other times."
                                                  (Linus Torvalds)