Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nvxdR-00008f-Lz for pgsql-bugs@arkaria.postgresql.org; Tue, 31 May 2022 08:53:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nvxdQ-0002Bw-IO for pgsql-bugs@arkaria.postgresql.org; Tue, 31 May 2022 08:53:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nvxdP-0002Bk-GS for pgsql-bugs@lists.postgresql.org; Tue, 31 May 2022 08:53:52 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nvxdM-0005Nc-QZ for pgsql-bugs@lists.postgresql.org; Tue, 31 May 2022 08:53:50 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8FCC35C01CE; Tue, 31 May 2022 04:53:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 31 May 2022 04:53:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1653987227; x=1654073627; bh=x CasRS0Gyx3+TGzi9YdqFYJGnPMmsJWqoMMd+7ryBeI=; b=a1mgx/jZ9H6U5jRTn nFNGEsCJQDdv20/TN/eSqaNkScRbzcWgNkZgXgLN40+obmJM4hHj13pIqiWJpI7K 8ZwxEPPlZeHLGCTyLSozvPSi6MmnCybpxipvZdeaTbfPRf/i6/cYh0Ruiw+T6TPf qtKIQOV3NqKH9sXikCFhCV4/dZ42uBeL9DBXQnge3RlsvoDnwW7CFeVXvX43LYLg frszpWC21POTgn/tMU9F4/TKUm4xMp9uvKR0xGWlqnxLW+lvAxVyujmdrAFt54Fo odxnDVZY/CBXz5u9bShF3FH6Ib6tvbZe/9BPadysrOjwVnYNkGDwSaFzB5SilIPV trXgQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrkeekgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeejkeff gfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 31 May 2022 04:53:47 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 10FA62A0843; Tue, 31 May 2022 10:53:45 +0200 (CEST) Date: Tue, 31 May 2022 10:53:45 +0200 From: Alvaro Herrera To: Michael Paquier Cc: Andres Freund , Andrey Borodin , Robert Haas , Peter Geoghegan , =?utf-8?B?0J/QtdGC0YrRgCDQodC70LDQstC+0LI=?= , PostgreSQL mailing lists Subject: Re: BUG #17485: Records missing from Primary Key index when doing REINDEX INDEX CONCURRENTLY Message-ID: <202205310853.c5xjegr4ojqb@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-May-31, Michael Paquier wrote: > On Mon, May 30, 2022 at 10:43:41PM +0200, Alvaro Herrera wrote: > > This is the full reversal in branch master. > > This looks fine to me, thanks. I can see that you have kept the > reference to ComputeXidHorizons for vacuum_defer_cleanup_age in > guc.c. Yeah, there was a typo fix there that I also kept as well as one newline change. Basically I scanned the reversal patch manually and removed the changes I thought were better kept. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "El miedo atento y previsor es la madre de la seguridad" (E. Burke)