Feedback-ID: ia2694551:Fastmail
Date: Tue, 31 May 2022 16:43:00 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Christophe Pettus <xof@thebuild.com>
Cc: Bruce Momjian <bruce@momjian.us>, Michael Paquier <michael@paquier.xyz>,
	Peter Geoghegan <pg@bowt.ie>, Robert Haas <robertmhaas@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	=?utf-8?B?0J/QtdGC0YrRgCDQodC70LDQstC+0LI=?= <pet.slavov@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17485: Records missing from Primary Key index when doing
 REINDEX INDEX CONCURRENTLY
Message-ID: <202205311443.5xshc44kp7ll@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <BB3FB2D1-9796-442B-AF11-08DFD0BF0F57@thebuild.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202205311443.5xshc44kp7ll%40alvherre.pgsql>
Precedence: bulk

On 2022-May-26, Christophe Pettus wrote:

> Unless we are 100% sure that amcheck will never return a false
> negative in this situation, we may have to recommend reindexing
> everything.

I am not aware of any reason why amcheck would return a false negative.
Is there any evidence behind this assertion?

If there is none, the recommendation should be to use amcheck on all
btree indexes and reindex those that have the problem; and reindex all
indexes of other AMs that could have been reindexed or created
concurrently in 14beta1 or later (implying: an index that was created in
13 and pg_upgraded but not touched afterwards is not at risk).

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/