Date: Wed, 8 Jun 2022 22:17:08 -0700
From: Noah Misch <noah@leadboat.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-bugs@lists.postgresql.org,
	=?iso-8859-1?Q?F=E4rber=2C_Franz-Josef_=28StMUK=29?=
 <Franz-Josef.Faerber@stmuk.bayern.de>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Extension pg_trgm, permissions and pg_dump order
Message-ID: <20220609051708.GA3615673@rfd.leadboat.com>
References: <f8a4105f076544c180a87ef0c4822352@stmuk.bayern.de>
 <1961551.1653498155@sss.pgh.pa.us>
 <20220526055047.GA3153526@rfd.leadboat.com>
 <20220528045122.GA3228881@rfd.leadboat.com>
 <20220529033033.GA1973706@nathanxps13>
 <20220529043403.GB3265235@rfd.leadboat.com>
 <YpWZ02YEN9pipA6M@paquier.xyz>
 <20220531152855.GA2236210@nathanxps13>
 <20220603181724.GA2672350@nathanxps13>
 <20220606063056.GA3527347@rfd.leadboat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220606063056.GA3527347@rfd.leadboat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20220609051708.GA3615673%40rfd.leadboat.com>
Precedence: bulk

On Sun, Jun 05, 2022 at 11:30:56PM -0700, Noah Misch wrote:
> On Fri, Jun 03, 2022 at 11:17:24AM -0700, Nathan Bossart wrote:
> > On Tue, May 31, 2022 at 08:28:55AM -0700, Nathan Bossart wrote:
> > > I've spent some time looking at all the code impacted by a117ceb and
> > > 0abc1a0, and I've yet to identify any additional problems besides the one
> > > with ResolveOpClass().  However, I'm far from confident in this analysis,
> > > and I still need to try out the ereport() approach that Noah suggested.  I
> > > would welcome any assistance identifying other problem areas.
> > 
> > Ah, I think I am missing something.  For example, the code that identifies
> > the exclusion operator (immediately following the call to ResolveOpClass())
> > is likely subject to a similar problem.
> 
> That would not surprise me.  Do you have what you need to continue?

I'll use that window on Sunday to review what you have.  If you have work in
progress, please get it to the mailing list by then.