Date: Tue, 21 Jun 2022 10:56:16 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Noah Misch <noah@leadboat.com>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-bugs@lists.postgresql.org,
	=?iso-8859-1?Q?F=E4rber=2C_Franz-Josef_=28StMUK=29?=
 <Franz-Josef.Faerber@stmuk.bayern.de>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Extension pg_trgm, permissions and pg_dump order
Message-ID: <20220621175616.GA93985@nathanxps13>
References: <20220528045122.GA3228881@rfd.leadboat.com>
 <20220529033033.GA1973706@nathanxps13>
 <20220529043403.GB3265235@rfd.leadboat.com>
 <YpWZ02YEN9pipA6M@paquier.xyz>
 <20220531152855.GA2236210@nathanxps13>
 <20220603181724.GA2672350@nathanxps13>
 <20220606063056.GA3527347@rfd.leadboat.com>
 <20220609051708.GA3615673@rfd.leadboat.com>
 <20220613034551.GB3728437@rfd.leadboat.com>
 <20220616054218.GA3980475@rfd.leadboat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220616054218.GA3980475@rfd.leadboat.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220621175616.GA93985%40nathanxps13>
Precedence: bulk

On Wed, Jun 15, 2022 at 10:42:18PM -0700, Noah Misch wrote:
> -REGRESS = citext citext_utf8
> +REGRESS = create_index_acl citext citext_utf8

It's a little unfortunate that these tests are located within the citext
module, but I can't claim to have a better idea.

> +		 * Identify the opclass to use.  Use of ddl_userid is necessary due to
> +		 * ACL checks therein.  This is safe despite opclasses containing
> +		 * opaque expressions (specifically, functions), because only
> +		 * superusers can define opclasses.

It's not clear to me why the fact that only superusers can define opclasses
makes this safe.

Overall, the patch seems reasonable to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com