Feedback-ID: ia2694551:Fastmail
Date: Fri, 5 Aug 2022 15:17:31 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: =?utf-8?B?546L5rW35rSL?= <wanghaiyang.001@bytedance.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: [External] Re: [PATCH] BUG FIX: inconsistent page found in
 BRIN_REGULAR_PAGE
Message-ID: <20220805131731.jhtscj2tonbglxz6@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ns56zz23hhgviqbt"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACciXACqJBkVAhj5pobKfgqGnYmqRu13YntFuuO8hZNLxYV=Yw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220805131731.jhtscj2tonbglxz6%40alvherre.pgsql>
Precedence: bulk


--ns56zz23hhgviqbt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2022-Aug-04, 王海洋 wrote:

> Thanks, I agree. So my new modified patch is attached.

I propose the attached.  This also adds a new TAP test that runs BRIN
through a revmap extension and through wal_consistency_checking.  This
increases coverage, as currently there's none for brin_evacuate_page.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Every machine is a smoke machine if you operate it wrong enough."
https://twitter.com/libseybieda/status/1541673325781196801

--ns56zz23hhgviqbt
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="v3-0001-add-test.patch"