Date: Mon, 17 Oct 2022 17:33:38 +0300
From: Ilya Anfimov <ilan@tzirechnoy.com>
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17646: create rule named "_RETURN" will cause pg core
Message-ID: <20221017143338.GA3864491@azor.tzirechnoy.ru>
Mail-Followup-To: Ilya Anfimov <ilan@tzirechnoy.com>,
	pgsql-bugs@lists.postgresql.org
References: <17646-70c93cfa40365776@postgresql.org>
 <2164336.1666016275@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2164336.1666016275@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20221017143338.GA3864491%40azor.tzirechnoy.ru>
Precedence: bulk

On Mon, Oct 17, 2022 at 10:17:55AM -0400, Tom Lane wrote:
> PG Bug reporting form <noreply@postgresql.org> writes:
> > here is a test case
> 
> > create table t (id integer);
> > create view v1 as select * from t;
> > create or replace rule "_RETURN" as on UPDATE to v1 do instead select * from
> > t;
> 
> Meh.  We should be preventing you from doing that.
> 
> (Although the core dump is also not great --- something should've noticed
> the bogosity of the plan earlier than this.)

 Id doesn't look much of a plan bogosity,
but rather implicit deletion of the "_RETURN" on select rule.

Consider the behaviour of the direct drop rule:

ilan=*> create table t (id integer);
CREATE TABLE
ilan=*> create view v1 as select * from t;
CREATE VIEW
ilan=*> DROP RULE "_RETURN" ON v1;
ERROR:  cannot drop rule _RETURN on view v1 because view v1 requires it
ПОДСКАЗКА:  You can drop view v1 instead.

> 
> 			regards, tom lane
>