Date: Wed, 2 Nov 2022 19:30:05 -0700
From: Noah Misch <noah@leadboat.com>
To: Helena =?iso-8859-1?Q?Zetterstr=F6m?= <helena.zetterstrom@chalmers.se>
Cc: "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: pg_upgrade fails if privileges have been granted on
 pg_start_backup()/pg_stop_backup() in the old cluster
Message-ID: <20221103023005.GA3400565@rfd.leadboat.com>
References: <3b3fc98f0d004c94b26def11d5e98360@chalmers.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3b3fc98f0d004c94b26def11d5e98360@chalmers.se>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20221103023005.GA3400565%40rfd.leadboat.com>
Precedence: bulk

On Wed, Nov 02, 2022 at 02:47:27PM +0000, Helena Zetterström wrote:
> In version 15 the functions pg_start_backup()/pg_stop_backup() have been renamed to pg_backup_start()/pg_backup_stop().
> 
> If privileges on these functions have been granted in the old cluster the pg_upgrade fails.
> Our barman user has been granted execute priviliges on these function in PostgreSQL 14 and to avoid the pg_upgrade to fail we had to revoke these privileges in the old cluster before running the pg_upgrade.
> No warning/notification is given about this when running pg_upgrade --check.
> I don´t know if this is a bug or not but it is really inconvenient to have the pg_upgrade fail/crash (child process exited abnormally: status 256) due to it being unable to grant execute on these no longer existing functions.
> It would have been good if a notification about this could have been shown when running the pg_upgrade with the --check option before performing the actual upgrade.

This thread was an unsuccessful attempt to fix that class of problem:
https://www.postgresql.org/message-id/flat/f85991ad-bbd4-ad57-fde4-e12f0661dbf0%40postgrespro.ru