Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAxcV-0006wH-G8 for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Dec 2022 18:27:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pAxcS-0000Bl-Mg for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Dec 2022 18:27:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAxcS-0000Bb-BZ for pgsql-hackers@lists.postgresql.org; Thu, 29 Dec 2022 18:27:08 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pAxcL-00055C-QO for pgsql-hackers@lists.postgresql.org; Thu, 29 Dec 2022 18:27:07 +0000 Received: by mail-pl1-x62f.google.com with SMTP id s7so19665417plk.5 for ; Thu, 29 Dec 2022 10:27:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Wt1yctRy4MC+oZ2Oe75eow/ySB5t73lL46UPCa8s3ac=; b=MOGpFqP/Uuc28/o86lSDaUBCwO5Bbdy2pErGNkQKtwgMICSWFTAK2AdAwUJMOZ5eXF 1Aqx9FbHEsONV2H5gA7KcSgfDdDM+8HrMnchjtSBrywUGcBcpfW98i8g8HskeFIuiTvt OAsRaBis73e/ujKL8pt2wTW8eG9BSrUL3JjOueI5zkf+Ib1J7Vyj8OL4UOaGtRApNe0C gCOlIHylnhtQgoYWYgMvQycLXwKH3xrLEE4bhWoKOjjdR/WL2yJXdL6UhC+W0bZck/5i qZ39ZXw8Xchk1f4nfYI6vhhXQ0BRFMQD+QRrY83JSU5yS/zjY2seMyOm9EIdq0F42dyU XNew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wt1yctRy4MC+oZ2Oe75eow/ySB5t73lL46UPCa8s3ac=; b=aq/PfJUHYkJ/9MbUdymcQa4ptapRpmh6aNVo0+TsBvXJuCXM5YCvZHPrrwBAUzquFc PngyH+ThRPsnVIXnBT0fH9k3H+jLCp3XD2VHLVbrWV4l8hb5frIqR195PgEmIxnker2V AiMm7DWGQpFtQwK4Igi8E7YXfCQz2mQU7DNpxAIZfoi0zvSgVfvUwnBdGhBGn9sUq96+ Vxjuvzk7Lt9kx/RUnxhPsSRwfqApHPltCdyHkdM3EcdveCDogP1X0q+mi+C8E0M1MZa0 XWR4N0TojI0s62iaZFTwtMU+zy4T1KrpL9gtdfxxjxjK3FndwJvWvTgjg9CKguJ51Gg6 B6IQ== X-Gm-Message-State: AFqh2kohmmyAnMm3U9HebA6poNu/WFhXjsaRO97IV7z5JTrwp1gToDlf WkMkdOOgdU3FWqjz5UE18yA= X-Google-Smtp-Source: AMrXdXsxg6BDH/SK+Gdj1SEUUztSZwaclXmCdskbeLqhmjt8tJVLUElcj4wlcDoE+dxgqBkiyNRxhA== X-Received: by 2002:a17:90b:1110:b0:225:c6fa:97cb with SMTP id gi16-20020a17090b111000b00225c6fa97cbmr22246754pjb.21.1672338419662; Thu, 29 Dec 2022 10:26:59 -0800 (PST) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id e17-20020a63d951000000b00460ea630c1bsm11084007pgj.46.2022.12.29.10.26.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 10:26:59 -0800 (PST) Date: Thu, 29 Dec 2022 10:26:57 -0800 From: Nathan Bossart To: Tom Lane Cc: Justin Pryzby , Peter Geoghegan , postgresql@taljaren.se, pgsql-hackers@lists.postgresql.org, Michael Paquier Subject: Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue) Message-ID: <20221229182657.GA165622@nathanxps13> References: <3439037.1671130590@sss.pgh.pa.us> <3544447.1671141436@sss.pgh.pa.us> <3672943.1671202149@sss.pgh.pa.us> <407579.1672258403@sss.pgh.pa.us> <20221229012354.GF1153@telsasoft.com> <451605.1672280274@sss.pgh.pa.us> <576868.1672334578@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <576868.1672334578@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Dec 29, 2022 at 12:22:58PM -0500, Tom Lane wrote: >> Justin Pryzby writes: >>> VACUUM (UPDATE_DATABASE_STATS {yes,no,only}) > VACUUM (DATABASE_STATS {UPDATE,SKIP,ONLY}) +1 for only introducing one option. IMHO UPDATE_DATABASE_STATS fits a little better since it states the action like most of the other options, but I think both choices are sufficiently clear. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com