Date: Sat, 21 Jan 2023 08:00:12 -0800
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>, justin@tonic.ai,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17753: pg_dump --if-exists bug
Message-ID: <20230121160012.GC1356297@rfd.leadboat.com>
References: <17753-9c8773631747ee1c@postgresql.org>
 <CAApHDvq+JTtZWOrXBrY7LvquyXHoCWWq=DfPYKB4b7BuFiM_8A@mail.gmail.com>
 <4062761.1674142680@sss.pgh.pa.us>
 <282372.1674166935@sss.pgh.pa.us>
 <294749.1674173390@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <294749.1674173390@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20230121160012.GC1356297%40rfd.leadboat.com>
Precedence: bulk

On Thu, Jan 19, 2023 at 07:09:50PM -0500, Tom Lane wrote:
> I wrote:
> > I think we need to do the attached, more or less.  Also, although the
> > given case seems to be new, we'd probably better back-patch, because
> > I'm not convinced that there aren't other ways to reach this.
> 
> Ah --- we only need to back-patch to v15, because this business of
> possibly having a comment in the dropStmt is new in a7a7be1f2.
> That commit also added the existing exceptions for comments in
> pg_backup_archiver.c ... but it missed the need to have special
> cases for dropStmts too.

Your commit 74739d1 looks good.  Thanks.