Feedback-ID: ia2694551:Fastmail
Date: Mon, 6 Feb 2023 16:43:00 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, takaram71@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17767: psql: tab-completion causes warnings when
 standard_conforming_strings = off
Message-ID: <20230206154300.ljxzsrulodicqqcd@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2663396.1675696783@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20230206154300.ljxzsrulodicqqcd%40alvherre.pgsql>
Precedence: bulk

On 2023-Feb-06, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Hmm, really?  We could just remove it for 16; people will still be able
> > to use the warnings mode in 15 for several years, so if they want to
> > upgrade to 16+ they will have plenty of time to update their apps.
> 
> I think removing standard_conforming_strings = off might be a
> bridge too far, even yet.  Or were you speaking of removing
> escape_string_warning?  I could get behind that perhaps.
> Making it default to off could be an even easier sell.

I was thinking we'd remove them together.  Anybody who is running
standard_conforming_strings=off will need the warning so that they can
find the places they need to touch in order to migrate.  Keeping the
ability to run nonstandard strings but without the ability to have the
warnings would be dangerous, because then there's no easy way to
upgrade.

So, if we want to keep standard_conforming_strings=off, then by all
means let's keep the warning too.

(I agree BTW with the idea that running psql with non-standard strings
and the warnings enabled is not something that we need to support
specifically.)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)