Feedback-ID: ia2694551:Fastmail
Date: Fri, 3 Mar 2023 12:21:44 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: ahodgson@simkin.ca, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17817: DISABLE TRIGGER ALL on a partitioned table with
 foreign key fails
Message-ID: <20230303112144.tzw3yeos2c5w3q6y@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1554133.1677703918@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20230303112144.tzw3yeos2c5w3q6y%40alvherre.pgsql>
Precedence: bulk

On 2023-Mar-01, Tom Lane wrote:

> Interestingly, although that commit was back-patched to v11, the failure
> does not occur in pre-v15 branches.  So what's different about v15?

Hmm, I think f4566345cf40 probably explains that.

> It's a reasonable bet that we're trying to look up the child trigger
> using the name of its parent trigger ... but why are we searching by
> name at all, rather than OID?  Seems mighty failure-prone.

I have no recollection of this, but we probably didn't have the OID
originally.  It may be that simply changing that is enough to solve the
problem.  I'll try to have a look later today, but I'm not sure I'll
have time.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/