Feedback-ID: ia2694551:Fastmail
Date: Fri, 3 Mar 2023 19:17:35 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: ahodgson@simkin.ca, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17817: DISABLE TRIGGER ALL on a partitioned table with
 foreign key fails
Message-ID: <20230303181735.quhcvh2igowmxbs7@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2473213.1677858640@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20230303181735.quhcvh2igowmxbs7%40alvherre.pgsql>
Precedence: bulk

On 2023-Mar-03, Tom Lane wrote:

> I wrote:
> > I can throw together a patch for what I was thinking of.
> 
> Basically just make the recursive steps match on tgparentid instead
> of name, like this.

Thank you, looks sane to me.

> I wonder whether anyplace else is making a similar mistake?  Although
> there's not much we will let you do to a foreign key trigger, so it
> might not matter for anything else.

Right ... triggers created in the normal way would have matching names,
so the previous code would work correctly.

I wonder how come this problem took so long to be detected with Ruby on
Rails; it's been in released 13.x and 14.x for seven months now.  I
suppose it would be very useful if the Ruby on Rails community would run
their tests more often on new Postgres versions (or even on the tip of
stable branches).

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
Y una voz del caos me habló y me dijo
"Sonríe y sé feliz, podría ser peor".
Y sonreí. Y fui feliz.
Y fue peor.