Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pr1eV-0001i1-Vt for pgsql-bugs@arkaria.postgresql.org; Mon, 24 Apr 2023 19:15:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pr1eT-0008BM-F2 for pgsql-bugs@arkaria.postgresql.org; Mon, 24 Apr 2023 19:15:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pr1eT-0008BA-47 for pgsql-bugs@lists.postgresql.org; Mon, 24 Apr 2023 19:15:05 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pr1eM-004qeI-2c for pgsql-bugs@lists.postgresql.org; Mon, 24 Apr 2023 19:15:04 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-63b35789313so3623251b3a.3 for ; Mon, 24 Apr 2023 12:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682363695; x=1684955695; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pJ51o2zFNGnX2PmXBvXjaFAbfS7vgVOPPfvmkXvHLeo=; b=LqtDFur1Ubh6+5PXgOoWgfZD4AWtkw7z75dcYjQWyUa0r/OFwMs2RcHhn7h3K30a72 +FfJV7G9NQ/DaNF+jtdVHSS54xrLC00UPWQQQ1ZqIuL2b828iijYL85du7/P9E5yGhBc BhYevIdraC6Khs8YHzpsr1xg1OEj4x0tiZ9NqEcvMzuJnGXrIvLU3QNPb6vr9tOLqo5i 0Lf+Opjir0/T6/xtpdpT188XNANBiAL7CSSin/gGo7XFxc8HeJN1Fg2ByFIeUuYwS+0K NoprHC4DnXqfxC3KrGsvl03M+jW0ayxoAiOIwu72VMNZqaP14+VZn4P6eSz8DC/YaAH9 yJIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682363695; x=1684955695; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pJ51o2zFNGnX2PmXBvXjaFAbfS7vgVOPPfvmkXvHLeo=; b=DE/GPt7MGo/I9rxPhV64AlhWAi5EUBwP7TZv3wPLkCaLANtk5RVoOnnOwK9s6wVplT 1GEukyFtL0iWO6+sMG5NafzjT5j1e+wBznkC9PJCWG63NJIzET4XadYw0xxyqijHji0K POuhpC8D0Ec/mjKA2cbxnusPdk5yY+SJvkElKEjLi1frXfLScQlePB/yTZfEcmphKLRq g9X8itZGlRJsHg8lEi7GSsu7ts4/il2HI1oXGisYHPaZUTOJ9ZvYjyxA73fs2zXEp+b7 jdQneOyVDRDfbIp0fFAQNDeW9dWpRlfS1ThWjEFKI1Q2lLSGV0bmKtvDcUuSAzNHFRos 6UuA== X-Gm-Message-State: AAQBX9f8OLpQrMstuW+vhJr/KXXGnnbA+Ceq3kWzfchlxNCZDGvcKJdb i5mYwX2KoXj3sjfivA5sbXCKA1IPcZc= X-Google-Smtp-Source: AKy350Y1jch/ag1p8nZElnK8n/NWelqgqGmfQWUNRzdf6mgvkLbxjIYgLIZ6UT20FzdvVEgCoOngmw== X-Received: by 2002:a05:6a00:814:b0:63c:1be4:5086 with SMTP id m20-20020a056a00081400b0063c1be45086mr21649157pfk.6.1682363695455; Mon, 24 Apr 2023 12:14:55 -0700 (PDT) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id n12-20020a056a00212c00b0063f172b1c47sm6201533pfj.35.2023.04.24.12.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 12:14:54 -0700 (PDT) Date: Mon, 24 Apr 2023 12:14:52 -0700 From: Nathan Bossart To: Kyotaro Horiguchi Cc: zhjwpku@gmail.com, xu.xw2008@163.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #17903: There is a bug in the KeepLogSeg() Message-ID: <20230424191452.GA1698829@nathanxps13> References: <20230420.175814.1157027125103997227.horikyota.ntt@gmail.com> <20230420220242.GB1435672@nathanxps13> <20230421.104231.1594652765237022266.horikyota.ntt@gmail.com> <20230421214347.GA1441786@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <20230421214347.GA1441786@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Here is a new version of the patch. It is fundamentally the same as v2, but I've adjusted the comment and commit message a bit. Barring objections, I am planning to commit this (and back-patch to v13) in the near future. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com --tThc/1wpZn/ma/RB Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v3-0001-Prevent-underflow-in-KeepLogSeg.patch"