Feedback-ID: ia2694551:Fastmail
Date: Mon, 12 Jun 2023 12:54:38 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Mo Youmiu <moyoumiu@outlook.com>
Cc: David Rowley <dgrowleyml@gmail.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17967: [msvc-x86] Failed to build with error LNK2019:
 unresolved external symbol __BitScanReverse64 referen
Message-ID: <20230612105438.5a4kzm4lcavf7joo@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <PSBPR01MB36080F188B2402AF683D9E64CC50A@PSBPR01MB3608.apcprd01.prod.exchangelabs.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230612105438.5a4kzm4lcavf7joo%40alvherre.pgsql>
Precedence: bulk

Hello Mo Youmiu,

On 2023-Jun-08, Mo Youmiu wrote:

> Thanks for your replies and corrections, and apologies for the confusing version I mentioned.
> 
> For this commit, PostgreSQL was successfully built with msvc on both x86 and amd64.
> 
> Glad my report was helpful.

You know what else would be extremely helpful?  A buildfarm animal that
runs with this configuration.  We should have noticed this problem as
soon as that problematic commit was introduced; a buildfarm animal would
have alerted us to it pretty much immediately rather than four months
after the fact.  Would you be in a position to running one?  It's a
moderately easy task, you just need to keep a machine (or VM) running
permanently.  You can find instructions here:
https://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto

Regards

-- 
Álvaro Herrera