Date: Thu, 27 Jul 2023 16:10:59 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>,
	Richard =?iso-8859-1?Q?Vesel=FD?= <richard.vesely@softea.sk>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: Fwd: BUG #18016: REINDEX TABLE failure
Message-ID: <20230727231059.GA3612597@nathanxps13>
References: <18016-2bd9b549b1fe49b3@postgresql.org>
 <ZKirERBzkM48E0op@paquier.xyz>
 <1457241.1688775601@sss.pgh.pa.us>
 <CABwTF4XCTA=guV=4v3xkQnKhtqKsW2njeKeZCNtDhSFoYRWfDQ@mail.gmail.com>
 <ZKpn+44jciv6Ym3/@paquier.xyz>
 <1867443.1688912310@sss.pgh.pa.us>
 <CABwTF4WX=m5pQvKXvLFJoEH=hSd6O=iZSqxVqHKjFm+iL-AO=w@mail.gmail.com>
 <20230726175000.GA3259285@nathanxps13>
 <CABwTF4U+t-8sD2y2xhgHyj=ovPMbrsNJO5F49nvZZtpwFkwWDA@mail.gmail.com>
 <CABwTF4VLS44Ypm90NsiGcyRbtdfioudUKcRUivXuQ8x1jPECPw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CABwTF4VLS44Ypm90NsiGcyRbtdfioudUKcRUivXuQ8x1jPECPw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230727231059.GA3612597%40nathanxps13>
Precedence: bulk

On Wed, Jul 26, 2023 at 06:42:14PM -0700, Gurjeet Singh wrote:
> On Wed, Jul 26, 2023 at 10:50 AM Nathan Bossart
> <nathandbossart@gmail.com> wrote:
>> On Mon, Jul 10, 2023 at 09:35:05AM -0700, Gurjeet Singh wrote:
>> > The code block movement involved slightly more thought and care than I
>> > had previously imagined. As explained in comments in the patch, the
>> > enumeration and suppression of indexes on the main table must happen
>> > before any CommandCounterIncrement() call, hence the
>> > reindex-the-toast-table-if-any code had to be placed after that
>> > enumeration.
>>
>> Do we need to add another CCI after reindexing the TOAST table?  It looks
>> like we presently do so between reindexing each relation, including the
>> TOAST table.
> 
> Yes, we do need to do a CCI after reindex the relation's toast table.
> But note that it is done by the recursive call to reindex_relation(),
> right after it calls reindex_index().

*facepalm*

Ah, I see it now.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com