IronPort-PHdr: A9a23:n8woUx/anfRPqP9uWTu7ngc9DxPPW53KNwIYoqAql6hJOvz6uci4b
 AqFuaQm3Q+BdL6YwswHotKViZyoYXYH75eFvSJKW713fDhBt/8rmRc9CtWOE0zxIa2iRSU7G
 MNfSA0tpCnjYgBaF8nkelLdvGC54yIMFRXjLwp1Ifn+FpLPg8it2O2+5Z7ebx9WiDeyZb5+I
 xG7oAbMvcQKnIVuLbo8xRTOrnZUYepawn9mK0yOlBjm/Mew+5Bj8yVUu/0/8sNLTLv3caclQ
 7FGFToqK2866tHluhnFVguP+2ATUn4KnRpSAgjK9w/1U5HsuSbnrOV92S2aPcrrTbAoXDmp8
 qlmRAP0hCoBKjU09nzchM5tg6JBuB+vqRxxzZPKboyLLvRxcaDTcs8BSGpEQspcWTZMDp+gY
 4YNCecKIOZWr5P6p1sLtRaxCg6sBOHzyjpWmnD23bAx3vk/HgHAwgMjEM8FvXPKrNXyNqcST
 f66w7XIzTnZdPxZxzH955bTch06vf6DQ7RwcdbLyUkyEgPJlEmfqI38Mj6Ty+8CvHSV4fB6W
 uKzl24otRtxoj63y8ojl4XEmpwZx0za+Shkzos7JcO1RU57b9OgEJZcqi6UOpV5T84gQ2xlu
 Ts2x7kJt5O6YSQHyYoqyhrfZfKHfYaF5A/oWuWJITpgi39oeaiziwiy/EWg0OHwSNe43VZQo
 iZbjtXBtmgB2wLJ5cSbVvdw+1qt1SuU2A3R7+xJL1w4mbbUJpMk3rEwmIYfvVjGEy/4hUn6k
 rOZe0Ar9+ez5enrfrDrqYSHOIJ6lw3zN6YjltKjDek8NAUFQnaW+eCh1L344U32Xq9KgOA3k
 qjYrp/XPdgXq6ikCAFPyIkj8QywDzK+3dQdmnkIMUxKdQqcj4jsJ1HOOPf4Deqjg1i0kDdk2
 fTGPrr5D5XCK3jDla3hca9z5kJG1AU809Zf545OCrEcJfL/QFP+td3AAh84NQy73frnBc1y2
 44fQ26DHK+UPaPIvVOW+O4iI/OAaJEJtDv9M/Ql4uThjX49mV8TZ6mp2p4XZWimHvRhIUWZf
 WTjjcsBEWsQpQUxUurqh0OZUTNIe3m9QaQ85i0hCIK7CIfPXJyigb2Z0Ce9BZJZfnpGBUyUE
 Xf0a4WEXO8BZSyKLs97jjMETaShS5Mm1Ry2qQD6xKBnLu3a+y0cq53i1N115+nImBE98Dx7F
 cWd02WXQ25omWMIQic63Lpjrkxl1leDza94juRAFdxc/PNJSwM6OYfHwOxnBNDyQRnMftOIS
 Fa9XtWmGis9Tso2w98Vf0Z9FM+igQ7Y3yqzB78ZjbuLBIY78q7ExXj+O959y2ra1Kkml1QmX
 sRPNWm9i65k7AjTHJTFk12Wl6aqb6gcxDTC+H2ezWqV7wlkV1skXarfWm8ba1rTqfz240rDS
 /mlDrFxdkMV1cGGArBRcZvxglUAXP6lJc+IMEyrnGLlOxGK2hCHbMLAdmMQLm2JFk8Gjw0Y/
 TCMOA4zHQ+qrmTCFiFrU1n9NRC/udJioW+2GxdnhzqBaFdsguLdxw==
IronPort-Data: A9a23:rarYe6kmsNSONjsHIL+gXkLo5gzkJ0RdPkR7XQ2eYbSJt1+Wr1Gzt
 xIcWm/TM66NZGb9ct0gaoWx9RwD6MWAmoJqTQM+qy1mEFtH+JHPbTi7wuYcHM8wwunrFh8PA
 xA2M4GYRCwMZiaA4E3ra9ANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq8wIDqtcAbeORXUXV5
 bsen+WFYAX5g2csbzpOg06+gEoHUMra6W5wUmMWOqgjUG/2zxE9EJ8ZLKetGHr0KqE88jmSG
 o4vZJnglo/o109F5uGNy94XQWVWKlLmBjViv1INM0SUqkMb+nFtiPZT2M00Mi+7gx3R9zx4J
 U4kWZaYEW/FNYWU8AgRvoUx/4iT8sSq9ZeeSUVTv/B/wGWWTXmv+q1KB30OfpEHwsIvG38Vy
 qMXfWVlghCr34pawZq0T+x2w59lJ8TtIJkCvzdr31k1D956H9aZHviMv4UFmm1o26iiHt6HD
 yYdQSRobgjNaB0JMFoRBYkWl+qummPidntTujp5oIJpszWIlFwhuFTrGNTYK9+BTsRRp0+/9
 zrN7j/rPD9HGOXKnFJp9Vrp3IcjhxjTVI0IE6K8++9vhHWcw2USDFsdUl7TieG2kVe6HthCJ
 Fc8/is1sbN07EuwUtbnUgahpDiDpBF0c8ZfF8Uh8xrL0qXUpR6QQHUfJgOtc/QpscosAGds3
 VKPg8n0AHpkotV5VE6gy1tdlhvqUQB9EIPITXVZJefZy7EPeL0Osy8=
IronPort-HdrOrdr: A9a23:9aGkZKnNrvhw4IHJUehQRwrHtjHpDfI43DAbv31ZSRFFG/FwWf
 rOoB17726RtN9/YhwdcLy7VJVoIkmsl6Kdn7NhWItKNTOO0ADDEGgI1+TfKlPbdREXIIVmpM
 RdmtNFaOHNMQ==
Date: Fri, 05 Jan 2024 18:39:32 +0100
From: =?utf-8?q?Vojt=c4=9bch_Bene=c5=a1?= <vojtech.benes@centrum.cz>
Subject: Re: BUG #18264: Table has type text, but query expects
 integer.attribute 1 of type record has wrong type
To: <dgrowleyml@gmail.com>, <tgl@sss.pgh.pa.us>
Cc: <pgsql-bugs@lists.postgresql.org>
MIME-Version: 1.0
Message-Id: <20240105183932.2D7B2BB4@centrum.cz>
Content-Type: multipart/mixed;
	boundary="_ca29_-------44287d575fc8af21aeeb8d3b1b838f1a"
Archived-At: 
 <https://www.postgresql.org/message-id/20240105183932.2D7B2BB4%40centrum.cz>
Precedence: bulk

This is a multi-part message in MIME format.

--_ca29_-------44287d575fc8af21aeeb8d3b1b838f1a
Content-Type: multipart/alternative;
	boundary="_d32c_-------7315ba88121be86cded025951ddb9efa"

--_d32c_-------7315ba88121be86cded025951ddb9efa
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

I am impressed with how quickly you addressed the issue. I tested queries m=
yself on latest builds and issue is resolved. Also all errors we were getti=
ng in more complex queries are gone.

=20
Thank you for your work.
Vojt=C4=9Bch
=C2=A0
______________________________________________________________
 > Od: "David Rowley" <dgrowleyml@gmail.com>
 > Komu: "Tom Lane" <tgl@sss.pgh.pa.us>
 > Datum: 04.01.2024 08:43
 > P=C5=99edm=C4=9Bt: Re: BUG #18264: Table has type text, but query expect=
s integer.attribute 1 of type record has wrong type
 >
> CC: <pgsql-bugs@lists.postgresql.org>
On Sun, 31 Dec 2023 at 16:24, David Rowley <dgrowleyml@gmail.com> wrote:
 > It looks like the problem is in ExecEvalPreOrderedDistinctMulti(). It
 > overwrites the tmpcontext's slots but fails to properly restore the
 > originals again.
=20
 I pushed a slightly revised version of this. =C2=A0I ended up adding a boo=
l
 isdistinct local variable so I didn't have to reset the slots in two
 places. =C2=A0It kinda makes it easier to see what the true and false
 means, so that might have been a good change regardless of the bug.
=20
 Thanks for reporting this Vojt=C4=9Bch and for the reproducer script.
=20
 David


--_d32c_-------7315ba88121be86cded025951ddb9efa
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p style=3D"padding: 0 0 0 0; margin: 0 0 0 0;"><span style=3D"font-size: 1=
3.3333px;">I am impressed with how quickly you addressed the issue. I teste=
d queries myself on latest builds and issue is resolved. Also all errors we=
 were getting in more complex queries are gone.</span></p>

<p style=3D"padding: 0 0 0 0; margin: 0 0 0 0;"><span style=3D"font-size: 1=
3.3333px;"><br />
 </span></p>

<p style=3D"padding: 0 0 0 0; margin: 0 0 0 0;"><span style=3D"font-size: 1=
3.3333px;">Thank you for your work.</span></p>

<p style=3D"padding: 0 0 0 0; margin: 0 0 0 0;">Vojt=C4=9Bch</p>

<p style=3D"padding: 0 0 0 0; margin: 0 0 0 0;">&nbsp;</p>

<p style=3D"padding: 0 0 0 0; margin: 0 0 0 0;">___________________________=
___________________________________<br />
 &gt; Od: "David Rowley" &lt;dgrowleyml@gmail.com&gt;<br />
 &gt; Komu: "Tom Lane" &lt;tgl@sss.pgh.pa.us&gt;<br />
 &gt; Datum: 04.01.2024 08:43<br />
 &gt; P=C5=99edm=C4=9Bt: Re: BUG #18264: Table has type text, but query exp=
ects integer.attribute 1 of type record has wrong type<br />
 &gt;</p>

<p style=3D"padding: 0 0 0 0; margin: 0 0 0 0;">&gt; CC: &lt;pgsql-bugs@lis=
ts.postgresql.org&gt;</p>

On Sun, 31 Dec 2023 at 16:24, David Rowley &lt;dgrowleyml@gmail.com&gt; wro=
te:<br />
 &gt; It looks like the problem is in ExecEvalPreOrderedDistinctMulti(). It=
<br />
 &gt; overwrites the tmpcontext's slots but fails to properly restore the<b=
r />
 &gt; originals again.<br />
 <br />
 I pushed a slightly revised version of this. &nbsp;I ended up adding a boo=
l<br />
 isdistinct local variable so I didn't have to reset the slots in two<br />
 places. &nbsp;It kinda makes it easier to see what the true and false<br /=
>
 means, so that might have been a good change regardless of the bug.<br />
 <br />
 Thanks for reporting this Vojt=C4=9Bch and for the reproducer script.<br /=
>
 <br />
 David<br />


--_d32c_-------7315ba88121be86cded025951ddb9efa--

--_ca29_-------44287d575fc8af21aeeb8d3b1b838f1a--