Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rMyxk-008DGQ-Qj for pgsql-bugs@arkaria.postgresql.org; Mon, 08 Jan 2024 23:23:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rMyxi-008DT2-Iz for pgsql-bugs@arkaria.postgresql.org; Mon, 08 Jan 2024 23:23:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rMyxi-008DSu-6U for pgsql-bugs@lists.postgresql.org; Mon, 08 Jan 2024 23:23:18 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rMyxf-000Ygu-5N for pgsql-bugs@lists.postgresql.org; Mon, 08 Jan 2024 23:23:16 +0000 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7bed9f0ea20so4882539f.2 for ; Mon, 08 Jan 2024 15:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704756194; x=1705360994; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2fDSvG43cgDOOfiKZ/wiHrEsKBFi2olNRFTTQfV0BM8=; b=an2eq+NTmH9GqsygE/Gn8d5UwmfbY0sKxanxXfunTbDcfSP87uhsd6YW2043+hhQYe IdQ788zzh4Hxqq6CGPSMIzNcaJJMoVJwqzgk15Ilcr3PTx8urUw/RBw0zM5BjIgWRFvE oSr++cShHXaO5xEURv+hd0E2xA/iXBsFQnVhflCIa8300Jqau81C305+bOiK9W7jyTQs Oh03vEbF7PrnyTqqNWi7S8OWrLaQJNJn8IqpVDhysmdIM23uWZMbVMTIXNcWLkivDk4R Pau7oWAdszrLhiVu0zxY8Q2Dwov1t6W60VXB0rRxrCl+kqwDaFvMnR0VhEnyaNiMrlPF eePQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704756194; x=1705360994; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2fDSvG43cgDOOfiKZ/wiHrEsKBFi2olNRFTTQfV0BM8=; b=el+I54DFaZIN/ZVpGhiCkuktHcpAI8/XEJFTIvwhbedGXFXiomjt70EmkjOklOEHfi ciSl7LL0KfNK0rs91y/CXaXlQQ3dkkw6/wG5Bi63Ug/TJDTfjucTOCyjWqbH1tV2X1az ROhTW84t4JLYQzPbRZx91s4AQ7Wo9QclY13xuzhZss56b0Tdia3QvCVLjqBiIs7Xzm7h C+axdVaA4/alqMhmfdBsNN1HFeFIyKYRbz6mKB+zFAvyzFkYdVnIb9e7KJD9Ugf31Cw4 CzZ+2/QdhAU6KTNhuXe6Kt3whqIH3o7Vq2fehEZjxFjvDWOREXuQwqMKfxcqqTcI9L/6 WyqQ== X-Gm-Message-State: AOJu0YxoWnoBbbOHUlmdJbc5HbmnFgm1fQz5g+Plx47S5DliXrQ/SwMP qVfc28ddyoKYrOWBo/9CGlVFKKNTyyw= X-Google-Smtp-Source: AGHT+IHPhCMF1knUMxAZsC/pkeMQfgwq0DtKUceJp3VVk8sn5Sl0i6HefG9XPkLv3Psn+liwK3A3RQ== X-Received: by 2002:a6b:c30d:0:b0:7bc:3ceb:6552 with SMTP id t13-20020a6bc30d000000b007bc3ceb6552mr5015188iof.5.1704756194234; Mon, 08 Jan 2024 15:23:14 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id x69-20020a0294cb000000b0046e1f0f6d92sm267871jah.76.2024.01.08.15.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 15:23:13 -0800 (PST) Date: Mon, 8 Jan 2024 17:23:11 -0600 From: Nathan Bossart To: hubert depesz lubaczewski Cc: PostgreSQL mailing lists , Robert Haas Subject: Re: Wrong datatype in docs for wal_summary_keep_time Message-ID: <20240108232311.GA3017966@nathanxps13> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jan 08, 2024 at 05:37:14PM +0100, hubert depesz lubaczewski wrote: > I was reviewing new changes, and found out that we now have > "wal_summary_keep_time" setting, but the docs > (https://www.postgresql.org/docs/devel/runtime-config-wal.html#RUNTIME-CONFIG-WAL-SUMMARIZATION) > say that it's boolean, while it is integer. Indeed. I'll try to get this committed tonight unless Robert beats me to it. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com