Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNG3f-00ATpD-TJ for pgsql-bugs@arkaria.postgresql.org; Tue, 09 Jan 2024 17:38:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rNG3f-00Eg09-0U for pgsql-bugs@arkaria.postgresql.org; Tue, 09 Jan 2024 17:38:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNG3e-00Efzt-Oj for pgsql-bugs@lists.postgresql.org; Tue, 09 Jan 2024 17:38:34 +0000 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rNG3b-000gaC-8q for pgsql-bugs@lists.postgresql.org; Tue, 09 Jan 2024 17:38:34 +0000 Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-429915eefa5so18894701cf.1 for ; Tue, 09 Jan 2024 09:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704821910; x=1705426710; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WpOktnwmixAXHtQR8Oay9q5KIoeh0XAZlNiyaC44z9Y=; b=Bh7vNnKytYe+NETrZObgjSgHLa0lsT2jKolCsuFK6YxCR5ahhzxYH+jvTIYcwhhTDg wnJgjZUwLBCwmhizcX+6akejGVGBd3/h706Ukr0PgPlqHDC+T0rxHnOjf3Qj+TrCC7Yr nv2TlPZnU1a5+pqv1PENkvQucXWF8VgsvVlxnmNae5n+iw8jYhaxMT3cAB1g29otOiFs 5ZbVFqDKIQSSeG5OwSwxco759YVzmtHxhmX0i4lNpJtkVCqbB9YLanXTjz2YkCl3fKaQ uCg3D+9EledhCTFn38H7dDn9Y9KIrV+6oppSrDCeNMJT0J2kzvmLucZzAZnb6l4LQ7Zk 0ofQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704821910; x=1705426710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WpOktnwmixAXHtQR8Oay9q5KIoeh0XAZlNiyaC44z9Y=; b=mDMUgnS5TH3583zg6YLOPiD9d71E7uXoRs0aUWxDi0BXO+6xMMXWof17s3+03ZFXjX GSKBv9YdfN6dU+HUj5PA3BXI4ocp3+EyxGTbEOa4uueUcxcltr9vmghKU2DrICI/fbKM t/SXzh49wPiLBweczYtwfiDf8BY+hp5ITK8s9Wqu3XYIJ882qYZgRPVg2mR3LBWfEJp5 j9aRQrrHxEY5aySJh4iu25tE4gznHlHoUWhvlISImIfeAnQu6EWQ8fcSSMNz5pN/EIfY 8/ubJkBGhdiANBkX2+QOgK1Jt58isdSWI75FdVgr3hFzAOzOFwah4UycW/5GoyiyQ3i0 Yu+A== X-Gm-Message-State: AOJu0YwAFP4ZqvLH7UGO8ens46Songdj/KPq50nKYUBkh4eumumzTQN2 ohczleTj9Ya++Qhvoc2D1m0= X-Google-Smtp-Source: AGHT+IGSK1r1YLRDZKgKE74H8HtyBpyMPr+aKrYD1FN6n0D8geNlYYsOzlLvPx9/w1ObxdXqJJbx9g== X-Received: by 2002:a05:622a:30e:b0:429:a455:bbf6 with SMTP id q14-20020a05622a030e00b00429a455bbf6mr1505024qtw.22.1704821909735; Tue, 09 Jan 2024 09:38:29 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id ay18-20020a05622a229200b00427fcfa42fbsm1037157qtb.70.2024.01.09.09.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jan 2024 09:38:29 -0800 (PST) Date: Tue, 9 Jan 2024 11:38:27 -0600 From: Nathan Bossart To: hubert depesz lubaczewski Cc: PostgreSQL mailing lists , Robert Haas Subject: Re: Wrong datatype in docs for wal_summary_keep_time Message-ID: <20240109173827.GA3254340@nathanxps13> References: <20240108232311.GA3017966@nathanxps13> <20240109034722.GA3031061@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240109034722.GA3031061@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jan 08, 2024 at 09:47:22PM -0600, Nathan Bossart wrote: > I noticed that the docs also fail to mention how the value of this > parameter is interpreted when specified without units, so I've put together > a v2 patch that fixes this, too. And committed. Thanks for the report! -- Nathan Bossart Amazon Web Services: https://aws.amazon.com