Date: Thu, 22 Feb 2024 16:00:27 +0900 (JST)
Message-Id: <20240222.160027.62383325429446607.horikyota.ntt@gmail.com>
To: tndrwang@gmail.com
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18354: Aborted transaction aborted during cleanup when
 temp_file_limit exceeded
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <20240222.143815.1856873109774774353.horikyota.ntt@gmail.com>
References: <20240222.114600.1019580904613326727.horikyota.ntt@gmail.com>
	<CAHewXN=ZEL1Rvw2fJmt8k3sO_3fb58gijv7GR-JnY8ujgGP0UA@mail.gmail.com>
	<20240222.143815.1856873109774774353.horikyota.ntt@gmail.com>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20240222.160027.62383325429446607.horikyota.ntt%40gmail.com>
Precedence: bulk

At Thu, 22 Feb 2024 14:38:15 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> At Thu, 22 Feb 2024 11:49:29 +0800, Tender Wang <tndrwang@gmail.com> wrote in 
> > Changing the behavior of tuplestore can work for this issue,  but I'm not
> > sure if this change will affect other components which depend on
> > BufFile(like nodeMaterial)

In the case of nodeMaterial, tuplestore is simply discarded and
underlying files are removed without flushing by the resource owner
mechanism. On the other hand, in the case of this bug report, the
files in the problem tuplestore are not managed by a resource
owner. As a result, PortalDrop have to explicitly call tuplestore_end
to release resources used by the tuplestore.

> 	/*
> 	 * Delete tuplestore if present.  We should do this even under error
> 	 * conditions; since the tuplestore would have been using cross-
> 	 * transaction storage, its temp files need to be explicitly deleted.
> 	 */
> 	if (portal->holdStore)
> 	{
> 		MemoryContext oldcontext;
> 
> 		oldcontext = MemoryContextSwitchTo(portal->holdContext);
> 		tuplestore_end(portal->holdStore);

As far as I can see, there are no caller sites to tuplestore_end in
the abort path or any error handling path.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center