Feedback-ID: ia2694551:Fastmail
Date: Fri, 24 May 2024 12:20:05 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: matthias.hoermann@saltation.com, pgsql-www@lists.postgresql.org
Subject: Re: BUG #18476: Debian Install Docs have confusing code block
 structure
Message-ID: <202405241020.updiuccxlbl2@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="cd46wsli6us33beo"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <18476-5cf162189c5c6dbc@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/202405241020.updiuccxlbl2%40alvherre.pgsql>
Precedence: bulk


--cd46wsli6us33beo
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Moved thread to pgsql-www.

On 2024-May-23, PG Bug reporting form wrote:

> On https://www.postgresql.org/download/linux/debian/ the commands to
> manually install the repository and the commands to install packages from
> the repository are in one big code block and the text before it suggests
> that this code block is optional if you use the script above it. However the
> script (without parameters at least) only installs the repository, not the
> packages from the repository. Maybe two code blocks were accidentally merged
> here and the text in between deleted?

I agree, it doesn't look good to have a button for "copy script" that
includes a line that installs a package after having enabled the repo.
Much less one that does so without asking for confirmation!  That line
should be separate.

I think the attached patch achieves that, but
1) it's untested
2) I'm not sure that a "Copy Script" button is really all that useful
for the "apt install" line, so maybe that part of this patch should be
scrapped.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"People get annoyed when you try to debug them."  (Larry Wall)

--cd46wsli6us33beo
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-Split-the-install-script-in-download-linux-debian.patch"
Content-Transfer-Encoding: 8bit