Feedback-ID: ia2694551:Fastmail
Date: Fri, 21 Jun 2024 14:39:11 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tender Wang <tndrwang@gmail.com>
Cc: 1026592243@qq.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18377: Assert false in "partdesc->nparts >= pinfo->nparts",
 fileName="execPartition.c", lineNumber=1943
Message-ID: <202406211239.45x55ljrrhcn@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="q7qwfurv5zp6qejb"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202406121953.gfdukghim5d2@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202406211239.45x55ljrrhcn%40alvherre.pgsql>
Precedence: bulk


--q7qwfurv5zp6qejb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

I noticed further problems with this patch, and it turned out to have
other bugs that would manifest under very high concurrency of detach and
attach (I think the problem was a detach followed by an immediate attach
of the same partition, or perhaps it was an attach of a neighboring
partition), so I spent more time ironing those out and ended up with the
following, which I'm rather embarrased not to have had as the previous
version because it looks simpler and more obvious.

Unless further surprises arise soon, I'll push this soonish.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Ellos andaban todos desnudos como su madre los parió, y también las mujeres,
aunque no vi más que una, harto moza, y todos los que yo vi eran todos
mancebos, que ninguno vi de edad de más de XXX años" (Cristóbal Colón)

--q7qwfurv5zp6qejb
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v4-0001-Fix-partition-pruning-setup-during-DETACH-CONCURR.patch"
Content-Transfer-Encoding: 8bit