Date: Thu, 11 Jul 2024 14:16:08 -0700
From: Noah Misch <noah@leadboat.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Bowen Shi <zxwsbg12138@gmail.com>, Andres Freund <andres@anarazel.de>,
	Robert Haas <robertmhaas@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Peter Geoghegan <pg@bowt.ie>,
	Alexander Lakhin <exclusion@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: relfrozenxid may disagree with row XIDs after 1ccc1e05ae
Message-ID: <20240711211608.21.nmisch@google.com>
References: 
 <CAAKRu_aUJ-yWy67QnytdNmvKjsAyZtVgnQpsdi-3hk_SbTL3Mg@mail.gmail.com>
 <CAAKRu_bXH2g_pchG7rN_4fs-_6_kVbbJ97gYRoN0Zdb9P04Wag@mail.gmail.com>
 <20240518222311.6b@rfd.leadboat.com>
 <CAAKRu_bCimXFX5aDr2wc1Z_6jbBdsO8u4f6w8s1J71+DvSnJRg@mail.gmail.com>
 <20240520204818.42.nmisch@google.com>
 <CAAKRu_YZeaS92OY02xFpgsgyLpEZaQ4DA5-s9GX97pp208ex7g@mail.gmail.com>
 <CAAKRu_aRuS-twZkrK1bY59H_9NMHWOdg8BnSofo6pfNowv9_Jw@mail.gmail.com>
 <CAAKRu_Y_NJzF4-8gzTTeaOuUL3CcGoXPjXcAHbTTygT8AyVqag@mail.gmail.com>
 <20240625193740.dc.nmisch@google.com>
 <CAAKRu_b=7e56UNog-Z=N2--bp42r0exckPAPfhruZBVRJHY9nQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAAKRu_b=7e56UNog-Z=N2--bp42r0exckPAPfhruZBVRJHY9nQ@mail.gmail.com>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20240711211608.21.nmisch%40google.com>
Precedence: bulk

On Mon, Jul 08, 2024 at 05:23:52PM -0400, Melanie Plageman wrote:
> I am nervous about the test flaking on the buildfarm. But I did
> the best I could to try to make it stable. I think keeping it as a
> separate commit should be easiest in case we have to revert it?

Whether one uses a separate commit or not, it's easy to remove a new test.  I
think either way is fine.  We've not typically committed tests separately.