Feedback-ID: ia2694551:Fastmail
Date: Wed, 24 Jul 2024 12:44:50 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18550: Cross-partition update of a former inheritance
 parent leads to an assertion failure
Message-ID: <202407241044.4auhbvwjgta2@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1080055.1721763503@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202407241044.4auhbvwjgta2%40alvherre.pgsql>
Precedence: bulk

On 2024-Jul-23, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

> > Yeah, that seems to work.  We can do that essentially for free in
> > StorePartitionBound(), like in the attached (which was taken in 14).
> 
> Looks sane.

Thanks for looking.

> > I'd add Alexander's script as a test too, somewhere near the bottom of
> > create_table.sql.
> 
> Personally I'd include this in the existing alter_table.sql test case,
> to save a few steps:

Nice!  Done that way.

I didn't see the connection between the assertion failure and
8f4a6b9e4f5b, but I didn't spend much time on it.  But I didn't see any
reason not to backpatch this all the way down, either, so I did that.

Thanks, Alexander, for reporting this.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
<Schwern> It does it in a really, really complicated way
<crab> why does it need to be complicated?
<Schwern> Because it's MakeMaker.