Date: Wed, 25 Sep 2024 14:55:54 +0200
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Tender Wang <tndrwang@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>, Alvaro Herrera
 <alvherre@alvh.no-ip.org>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18628: Race condition during attach/detach partition
 breaks constraints of partition having foreign key
Message-ID: <20240925145554.57233b76@karst>
In-Reply-To: 
 <CAHewXNk3NcN6-EtB9brCsW_ps_GZHztGmveTUPuZvrgBz75-HA@mail.gmail.com>
References: <202409241123.dnrn6pdmoud6@alvherre.pgsql>
	<4fe75dda-d8cc-1763-9741-e1efdaed33d4@gmail.com>
	<CAHewXNk3NcN6-EtB9brCsW_ps_GZHztGmveTUPuZvrgBz75-HA@mail.gmail.com>
Organization: Dalibo
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/20240925145554.57233b76%40karst>
Precedence: bulk

On Tue, 24 Sep 2024 21:10:48 +0800
Tender Wang <tndrwang@gmail.com> wrote:

> Alexander Lakhin <exclusion@gmail.com> =E4=BA=8E2024=E5=B9=B49=E6=9C=8824=
=E6=97=A5=E5=91=A8=E4=BA=8C 20:00=E5=86=99=E9=81=93=EF=BC=9A
>=20
> > 24.09.2024 14:23, Alvaro Herrera wrote:
> > > I suspect this is the same problem that was reported by Jehan-Guillau=
me
> > > de Rorthais, for which there are two patches proposed, his and mine:
> > >
> > > [1] https://postgr.es/m/202408072250.2c4fkhwf56lk@alvherre.pgsql
> > > [2] https://postgr.es/m/20240905005728.0836d609@karst
> > >
> > > I haven't looked at his patch, but I suspect it's better than mine on
> > > maintainability grounds.  I think his code causes more catalog churn,
> > > though perhaps we don't care too much about that in this particular
> >
> > Yes, v2-0001-Rework-foreign-key-....patch works for me =E2=80=94 the pa=
rtition
> > detached with no error.

I just sent the v3 set of patchs, rebased against head (it was conflicting =
with
new temporal FK).
See: https://www.postgresql.org/message-id/20240925144240.2b579a27%40karst

Testing your scenario against current head fails.
Testing your scenario against the v3 set of patchs doesn't show the error.

Regards,