Date: Thu, 3 Oct 2024 19:33:37 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>, usamoi@outlook.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18637: CREATE INDEX won't look up operator classes in
 search_path if PARTITION BY is specified
Message-ID: <20241004023337.36.nmisch@google.com>
References: <18637-f51e314546e3ba2a@postgresql.org>
 <CAApHDvrmBSTA8-Sv=HEQvrPO8QDPLB7y0d0gJweBQe2c8PMGYw@mail.gmail.com>
 <231375.1727925543@sss.pgh.pa.us>
 <364851.1727974294@sss.pgh.pa.us>
 <427540.1727979435@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <427540.1727979435@sss.pgh.pa.us>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20241004023337.36.nmisch%40google.com>
Precedence: bulk

On Thu, Oct 03, 2024 at 02:17:15PM -0400, Tom Lane wrote:
> This could stand an additional regression test case perhaps,
> but the core tests don't have a suitable opclass at hand.
> Maybe we could test it in some contrib module, but that
> seems a shade hacky.
> 
> Thoughts?

For contrib/citext/sql/create_index_acl.sql, I settled on testing in contrib.
I valued the test fidelity of a real opclass more than I disliked the use of
contrib.  The distinction between the various parts of check-world is blurry
to non-hackers, so I expect it won't bother them.