Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uA4wM-00AK06-II for pgsql-bugs@arkaria.postgresql.org; Wed, 30 Apr 2025 10:45:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uA4wJ-00DAiH-Ve for pgsql-bugs@arkaria.postgresql.org; Wed, 30 Apr 2025 10:45:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uA4wJ-00DAi7-0v for pgsql-bugs@lists.postgresql.org; Wed, 30 Apr 2025 10:45:20 +0000 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uA4wH-000LWi-0i for pgsql-bugs@lists.postgresql.org; Wed, 30 Apr 2025 10:45:19 +0000 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id A61491380E7E; Wed, 30 Apr 2025 06:45:14 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Wed, 30 Apr 2025 06:45:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1746009914; x= 1746096314; bh=kMOn37qhqgvAFKadmOLAd2q8zC+cnV4+2hOU3eavAw0=; b=A 6XIXb8VwFFPlRkIqH5Ytlad2+qP9KiTody1UcwDIfYnjySD0NnR+FxfjLRfDqHUv 3TmOlXsvo83W8Ov2gtInuaHHFC4QME5LbKrbPEkJDnaPW0o7sm5/Rv8vTbY2Eqiw iQuFdhVj4qtsfiIQTH9CVWS9N/9n3UmJeN4rJmNAMbx3nAaIzdxiTiCzm9ZIpONz GWA5dWIRRnGSclgCijlVsB4sD/XfozwNKI95dMUQlJ+MFENoHJW1e4v8GygZYWnu Ame1TnUUFGWXinRq220SydTfhAF931mSa3LJ7Av+p1xW4WkADWqavBcCBR5Xw/oG abXsPryXqK3607sYWHLhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1746009914; x=1746096314; bh=k MOn37qhqgvAFKadmOLAd2q8zC+cnV4+2hOU3eavAw0=; b=KNnYeiqMD9SK9OzwP ErXStF4wdW3hnvisqWN0+gpeFI8UPuB/efNQL4QXEeaM10PlB2exJ7bwpfxUi9OS hl2R7t2J/8kcHHQaBWGKhaPQyty6gXoMbIEG9FDDOz5/iuvJh8pws3Y9yYgIGDj9 Ld/MTK1rrPkdi6sVq4CHHrm6BnAimxTYlQi8L4r1KILEj9HRgVOfnJiq0Ir1szFS 3+2taGYW0Z5XI45zzii6w2cF9Kyy7lHfSbaXjQ3gO72Gk5ZIF+1b3jFsXYwhA+TW mhuaqUT1qbVYYB+6BYrr9K0TM0COAyw53Bl0m7xCMwm367GnmaQF9Om564cLiuob h1rnw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieeigeelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkgggtugfgjgesthekredttddt jeenucfhrhhomheplmhlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuh hrihhlvghmuhdruggvqeenucggtffrrghtthgvrhhnpeetuedvheffkeevgfeuheevteev kefggedttdeufeeuheduuddthfeffffhjeefffenucffohhmrghinhepvghnthgvrhhprh hishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomheprghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtth hopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjrghpihhnlhhisehhohht mhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqsghughhssehlihhsthhsrdhpoh hsthhgrhgvshhqlhdrohhrghdprhgtphhtthhopehkvghithhhrdhprghskhgvthhtsehl ohhgrghnshifrdgtohhm X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Apr 2025 06:45:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1746009911; bh=Y6QZ1GoKgzfibt3l3NjJy0YXJUSlk38LeaGg5kEcanU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tzrQZP/GAJIddsB39h3HOhl8ZtR1gaym2mhdtUext4zx9nwpwds8AVwS7Y/0/DK2v Bjq5mrpZPghmZcPly+PP8KwyHXr+mI7eyeiDo0LbOR7vIsaanqAW8yhdYeSeTcv7GC l7xuBhsI6Yh7PwwJXQA9nEnVvimcR9KYGBkCQDAQFWd+dcCe/4z5FVOc23z1r9lS98 ahRHqSjtuFSFL/6G7ydYidq/dGefNXT4E4dPdwpxQkoQ/UEDmeZaVNo9G1i37ax5Qo jS0EIxnL8chZJpchJ8gLIlo/EHuyWeKRkCIsLX7r1pIA/NikIOVUDM40KVlC5i72TR rwnffVsU7qKog== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 1BDF790; Wed, 30 Apr 2025 12:45:11 +0200 (CEST) Date: Wed, 30 Apr 2025 12:45:11 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Japin Li Cc: Keith Paskett , pgsql-bugs@lists.postgresql.org Subject: Re: pg_restore error with partitioned table having exclude constraint Message-ID: <202504301045.7cjojr7ut2fo@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Apr-30, Japin Li wrote: > Thank you for the explanation. A test case has been added to create_index.sql. > Could you please take a look? Well, it seems a bit minimalistic -- I would try to be more adversarial about it maybe, because details are where devil(s) lie. You need to add comments in CompareIndexInfo about your new code. Why is it okay to ignore ii_ExclusionProcs and ii_ExclusionStrats? Why is it okay to not have tests that set up tables with those things as different so that this function returns false in these cases? Why do you have a test for a table set up where the positive case is handled, but no case for the negative case? -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/