Date: Thu, 15 May 2025 12:25:59 -0500
From: "Karl O. Pinc" <kop@karlpinc.com>
To: pgsql-bugs@lists.postgresql.org
Subject: PGXS does not properly uninstall documentation
Message-ID: <20250515122559.067c4ee0@slate.karlpinc.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="MP_/A4+849Z.byp+qSkZW+=bEh/"
Archived-At: 
 <https://www.postgresql.org/message-id/20250515122559.067c4ee0%40slate.karlpinc.com>
Precedence: bulk

--MP_/A4+849Z.byp+qSkZW+=bEh/
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

When using PGXS, putting a pathname, as opposed to
just a file name, into DOCS means that file won't
uninstall.

When installing documentation via the DOCS variable,
the Makefile runs `install`, which installs a single
file into a directory somewhere, regardless of the
source path.  But the source path is what's in DOCS,
so when uninstalling the Makefile must strip the
directory part from what's in DOCS when deleting the file.

Makefile patch attached.

Regards,

Karl <kop@karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

--MP_/A4+849Z.byp+qSkZW+=bEh/
Content-Type: application/octet-stream; name=pgxs_doc_bug
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename=pgxs_doc_bug

ZGlmZiAtLWdpdCBhL3NyYy9tYWtlZmlsZXMvcGd4cy5tayBiL3NyYy9tYWtlZmlsZXMvcGd4cy5t
awppbmRleCAwZGUzNzM3ZTc4Li4yMTNmZjNhMjQyIDEwMDY0NAotLS0gYS9zcmMvbWFrZWZpbGVz
L3BneHMubWsKKysrIGIvc3JjL21ha2VmaWxlcy9wZ3hzLm1rCkBAIC0zMjAsNyArMzIwLDcgQEAg
aWZlcSAoJCh3aXRoX2xsdm0pLCB5ZXMpCiBlbmRpZiAjIHdpdGhfbGx2bQogZW5kaWYgIyBNT0RV
TEVTCiBpZmRlZiBET0NTCi0Jcm0gLWYgJChhZGRwcmVmaXggJyQoREVTVERJUikkKGRvY2Rpcikv
JChkb2Ntb2R1bGVkaXIpJy8sICQoRE9DUykpCisJcm0gLWYgJChhZGRwcmVmaXggJyQoREVTVERJ
UikkKGRvY2RpcikvJChkb2Ntb2R1bGVkaXIpJy8sICQobm90ZGlyICQoRE9DUykpKQogZW5kaWYK
IGlmZGVmIFBST0dSQU0KIAlybSAtZiAnJChERVNURElSKSQoYmluZGlyKS8kKFBST0dSQU0pJChY
KScK

--MP_/A4+849Z.byp+qSkZW+=bEh/--