Feedback-ID: ie3de48e3:Fastmail
Date: Thu, 17 Jul 2025 14:03:11 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, exclusion@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18984: Empty prepared statement from psql \parse triggers
 assert in PortalRunMulti
Message-ID: <202507171203.y6yp2n25fk6f@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <905237.1752591474@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202507171203.y6yp2n25fk6f%40alvherre.pgsql>
Precedence: bulk

On 2025-Jul-15, Tom Lane wrote:

> I might write the replacement comment more like
> 
>      * If query completion data is requested and not yet filled in,
>      * and the portal has a default command tag, copy it from there.
>      * See QueryRewrite(), step 3, for motivation.

I've been wondering what does the "a default command tag" mean there. 
I couldn't find a reference for a command tag being default.  Would it
work to say "... and the portal has acquired a command tag [during
execution above?], ..." ?

Thanks,

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Once again, thank you and all of the developers for your hard work on
PostgreSQL.  This is by far the most pleasant management experience of
any database I've worked on."                             (Dan Harris)
http://archives.postgresql.org/pgsql-performance/2006-04/msg00247.php