Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ujiVL-00BB4M-2R for pgsql-bugs@arkaria.postgresql.org; Wed, 06 Aug 2025 18:04:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ujiVI-00HW7B-TC for pgsql-bugs@arkaria.postgresql.org; Wed, 06 Aug 2025 18:04:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ujiVI-00HW73-IX for pgsql-bugs@lists.postgresql.org; Wed, 06 Aug 2025 18:04:44 +0000 Received: from fhigh-b2-smtp.messagingengine.com ([202.12.124.153]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ujiVF-0016pi-2y for pgsql-bugs@lists.postgresql.org; Wed, 06 Aug 2025 18:04:44 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id 0B6EF7A00E6; Wed, 6 Aug 2025 14:04:40 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Wed, 06 Aug 2025 14:04:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1754503479; x= 1754589879; bh=4IKFgbLCf146pAGYEhPp8IoNo21eKDYNTIrvAy9LlNE=; b=b gdDNdyibqohvIzCBQyXAe+pfWWwbpKi4/MPWKProK7iJxnHME4iyA+XuSC8S14Qi imMFP7HBQKZX+iYfHvmdAZXbFeedrSfVTA/dBOK2ZQ7qsavkQB+3xL8xhN//TzLJ HmGk6lN5CO6OBW8FgFLInKIW6Jm21DtceTPQq+zidkC4/DZoOKKbQXiz5JJEJybS imNHp3oAKFu72VNgW4Egy0nmxPxjuZ6Nm62YTJCsQ775cQTcKk553qpFr4Xyxffg ETSLUtbDob1DNArEvG9p86xiOy+/4HF9qXVAYh1TvOErVggatcDorrqPA9pB2bvn IytwRGn4+LwBjverI/lJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1754503479; x=1754589879; bh=4 IKFgbLCf146pAGYEhPp8IoNo21eKDYNTIrvAy9LlNE=; b=IDGmYuDcJO8pl6YQx VWq/BpW63Nf5sqhy5lEQXBKnk6TPjIuh08DjgqR9it+hZEl9O7sfAenJ4nUSSFI2 p3lObYhAftlKlxqEm6y6/pYMrLTSKOPFuG486W6FZJEOocxSX2tYQmVOjK3/5bPx Ruf0A37LbxKwxwGJAJsN6HJ5Q7mkoIW8ugQHNAhVxOFt9br00ZCV3yvK9en/7Wev ci5ctfu88rPrlUlEqo2IhF9puAfYa5kBpDVWBnHgo+T6yWNZKz8IZJMluqkctDo7 lALdUkk0Lp6zW5iHHQBM0ZUbF5fSEy8zg7iEBLUpT0ZiFvhlJJZ2UkbiE5DflEVp lfTNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdduudekjedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopegurghvihgurdhgrdhjohhhnhhsthhonhesghhmrghilhdrtgho mhdprhgtphhtthhopehpghhsqhhlqdgsuhhgsheslhhishhtshdrphhoshhtghhrvghsqh hlrdhorhhgpdhrtghpthhtohepuggsmhgrnhesshhqlhgvgigvtgdrtghomh X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Aug 2025 14:04:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1754503477; bh=AKy58p3drLy+7GeK/3VCKvyH8O9duAN6kRbTMW+xHpY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=0I7k9oWzAmvP5YB8gmLVl0QDyw+YLU2eHJRYJXnZvEZ2DtVk4kDV11vFPJ/QgHBoU LAijNGfRiwxgLYiN0t8dMeHjDg3wo6nv/EPrFiBVAi8f40ZjZ2K1e6sqrukEVx08Ep VrlB2gsg21A+z4v3jHG0djUvJpDn0uMyJXV88JjppZWa3tf0AeULnbTKQqPXL5hLwQ Bbusv2J+/wTuRAgv5q6xwGOffMyeMZ1jHGrBnEzIxP3FtPIDcmrRykoWEDkUDc2lZ1 Lt6DNvRlAGcQ7pykua3cmO28ryXOE/pZ5VAVImGDOQxNVYzxdyptU9eH+yTrh29iol d4P3gEUbVgwxg== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 6779D90; Wed, 6 Aug 2025 20:04:37 +0200 (CEST) Date: Wed, 6 Aug 2025 20:04:37 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: "dbman@sqlexec.com" Cc: "David G. Johnston" , "pgsql-bugs@lists.postgresql.org" Subject: Re: BUG #19013: When creating a table with the "...LIKE...INCLUDING ALL" construct, REPLICA IDENTITY output is wrong Message-ID: <202508061804.wwf4zc7npayp@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Aug-06, dbman@sqlexec.com wrote: > Good point aboutg the default value for pg_class.relreplident is always "d", > but maybe it should be "n" which indicates there is no REPLICA IDENTITY.  I think this behavior is just an oversight made when replica identity was introduced. Commit 07cacba983ef didn't touch the CREATE TABLE LIKE code. To me, it makes sense to copy the replica identity definition if INCLUDING INDEXES or INCLUDING CONSTRAINTS is given. Patching released branches seems out of the question (it might disrupt working workflows), but for 19 it isn't, if we agree on an ideal behavior. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)