Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1utmbP-00Dzhy-AX for pgsql-bugs@arkaria.postgresql.org; Wed, 03 Sep 2025 12:28:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1utmbO-009Qjx-FD for pgsql-bugs@arkaria.postgresql.org; Wed, 03 Sep 2025 12:28:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1utmbN-009Qjm-UD for pgsql-bugs@lists.postgresql.org; Wed, 03 Sep 2025 12:28:38 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1utmbL-000KXF-33 for pgsql-bugs@lists.postgresql.org; Wed, 03 Sep 2025 12:28:37 +0000 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id BD8E31400431; Wed, 3 Sep 2025 08:28:34 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Wed, 03 Sep 2025 08:28:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm2; t=1756902514; x= 1756988914; bh=JBDzrLmImej0ou4rAX9/59C+PykrAYQVmWPSf4h+/EA=; b=r GE34VTS1zyZTl95Udnz2xzAxr+OmA1iM3l1tuJG20rGPkxVp4uhW/qCslH/wqLtN xFcU/Vm/BmDa4QuSsB8qySp32uqYjTGzQJD86WziFJjJUnqDXYIUlwoV2Zg/+bTa jdZTnFLCrf978kVyQi9Q6G2Mc7MvrZ87JudSLLuWqSgf+A4XQ+tw/h3m+MVQSUOK HyWe14N3DsYsi3AZHJyggsb1Z0YeblxcF5S5TT9zokPn2P+PQyTS4XVan2JWUTUV kVdT6yysa3CnzHd2xL7YJrx0qBOHuGxDyRtSonT1dFZZvW7wKwcv+Nq9wJrkRDEA oGN+TZyleIPwWX5bizOcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1756902514; x=1756988914; bh=J BDzrLmImej0ou4rAX9/59C+PykrAYQVmWPSf4h+/EA=; b=LMZqA5QqVjI0gwbpK TQg9DV4QsCumpLeSyQUW2Ozb6oDu8fGFocFQ8gyps0OhPLhhqvjRSEoNDmdNsYwL 7Ix1X74fuMlqZFkf+I0dGP6PmOVttd3pG+KIEragesEH47W+q0/KRd99TefBK1V6 6TTj7c96abqOVa3+OkM6jueki8akj0rhIBDvkTFiOo1kbaMZIL2Wmg9PJ2GaukdN cygBw5lQyLhcnncKkVGHewC19fGLZ73puQXGaXej3U3Of+2uiXI/Oamo0dxDfEz9 t+2QIhm34RI8ys6ZM0D3Fxa/UYe6QtGytvdorqhJJwQTSd63URdxZACm+RoMGFWy JsY7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdefudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfggtggugfgjsehtkeertddttd ejnecuhfhrohhmpemllhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgeskhhu rhhilhgvmhhurdguvgeqnecuggftrfgrthhtvghrnhepteeuvdehffekvefgueehveetve ekgfegtddtueefueehuddutdfhfeffhfejfeffnecuffhomhgrihhnpegvnhhtvghrphhr ihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgdpnhgspghrtghpthht ohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepphhgshhqlhdqsghughhsse hlihhsthhsrdhpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtthhopegurdhkohhvrghl vghnkhhosehpohhsthhgrhgvshhprhhordhruhdprhgtphhtthhopehtghhlsehsshhsrd hpghhhrdhprgdruhhs X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Sep 2025 08:28:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1756902510; bh=42TQC7Rlvm9vuPyWNfMRtrdckq1T9V0LJfHzwB34Mvw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=vFawY0twsawdjM5wU0vzEkht0hCns9Ti5MrGFWEdBH8m0WBJ0Hk5syyVdlBFD5X7B cMbXFXA9l1/hfLFL8tcyNn3npvP9AU1Hl1uP/96sSieJHl18SHupDtCZF07RKcF2PP x8BEkcg2dY61I2ttnMabtCtXtejr4NJGJSXUR9k4SJgg+DDOBxjAMHhPl2mG9rg7EM +MVYhmbSIFNg07MSu2176X1obbSKWGyj/cyiYu9nyjGSU4FFZj/t0DvVGp0+bNprEp ugVBU12xCp5gCZXDPMz+7BVvwudjnGg/sqTyKP1WjsWeHGlyyWTAxNzXlTBbPqpeeq d9jcPYwhZx8Zw== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id AD1398D; Wed, 3 Sep 2025 14:28:30 +0200 (CEST) Date: Wed, 3 Sep 2025 14:28:30 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Tom Lane Cc: d.kovalenko@postgrespro.ru, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c) Message-ID: <202509031228.wuh3frddxcvl@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2790652.1750536063@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Jun-21, Tom Lane wrote: > Here's a shot at improving matters. I also made an effort > at cleaning up memory leaks in libpq_pipeline.c, although > that's surely neatnik-ism not anything meaningful. Yeah, the code looks much better this way. I thought it was a bit odd that a function called confirm_result_status() would actually consume said status. Would it be better as consume_result_status(PGconn *conn, ExecStatusType expected) ? I think the patch is a clear improvement regardless. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "World domination is proceeding according to plan" (Andrew Morton)