Feedback-ID: ie3de48e3:Fastmail
Date: Sat, 18 Oct 2025 18:22:16 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>, andrewbille@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the
 inherited table field when dumping v17-databases
Message-ID: <202510181619.crppv2bdx2xm@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAFiTN-sfxzgd1ntJx=GPjsbvEkA-0YeaLsKdzMm=X5aUSDqL9g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202510181619.crppv2bdx2xm%40alvherre.pgsql>
Precedence: bulk

On 2025-Oct-06, Dilip Kumar wrote:

> I think we can fix it in getTableAttrs(), see attached, with that I
> can see my dump is correct.  This is just a quick way to show what I
> am thinking, maybe we can improve this condition.

Pushed, thanks.  I added a test so that cross-version upgrade will hit
this.  Because this code is not used except when upgrading from 17 or
older, I had to modify 17 even though that version needs no code changes
itself.  (I verified that the pg_upgrade test fails if I have this table
in a pg_dumpall from version 17 -- and the diff is exactly this missing
NOT NULL constraint.)

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)