Feedback-ID: ie3de48e3:Fastmail
Date: Sat, 21 Feb 2026 14:45:31 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: huseyin.d3r@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19393: pg_upgrade fails with duplicate key violation when
 CHECK constraint named *_not_null exists
Message-ID: <202602211203.n22ngw4ys4dj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202602211127.yhfjy43if2kk@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/202602211203.n22ngw4ys4dj%40alvherre.pgsql>
Precedence: bulk

On 2026-Feb-21, Álvaro Herrera wrote:
> 
> 1. this will cause an ABI break report for AddRelationNotNullConstraints
> in branch 18.  I considered the idea of adding a shim function
> preserving the original API, but I think this is not a function likely
> to be used by third-party code.  So I'll address this by adding an entry
> to .abi-compliance-history instead.

As expected, crake reported:

Leaf changes summary: 1 artifact changed
Changed leaf types summary: 0 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 1 Changed, 0 Added function (13 filtered out)
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 0 Added variable

1 function with incompatible sub-type changes: 

  [C] 'function List* AddRelationNotNullConstraints(Relation, List*, List*)' has some sub-type changes:
    parameter 4 of type 'List*' was added


I have pushed the update to .abi-compliance-history, and crake is now green.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Cómo ponemos nuestros dedos en la arcilla del otro. Eso es la amistad; jugar
al alfarero y ver qué formas se pueden sacar del otro" (C. Halloway en
La Feria de las Tinieblas, R. Bradbury)