Feedback-ID: ie3de48e3:Fastmail
Date: Wed, 25 Feb 2026 17:57:59 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Vishal Prasanna <vishal.g@zohocorp.com>
Cc: kurodahayato <kuroda.hayato@fujitsu.com>, 
	pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: [BUG] Assert failure in ReorderBufferReturnTXN during logical
 decoding due to leaked specinsert change
Message-ID: <202602251653.e66kyhiyntlm@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <19c95a57600.599bb79483132.9142801067257165882@zohocorp.com>
Archived-At: <https://www.postgresql.org/message-id/202602251653.e66kyhiyntlm%40alvherre.pgsql>
Precedence: bulk

On 2026-Feb-25, Vishal Prasanna wrote:

> > It looks OK for me. In this case an argument should be reduced from 
> > ReorderBufferResetTXN(), right? It is harmless because the function is a static one.
> 
> Yes, the `specinsert` is no longer needed in
> `ReorderBufferResetTXN()`. Updated the patch where `specinsert`
> cleanup is now handled in the `PG_CATCH()` block of
> `ReorderBufferProcessTXN()`, so it is always freed before the if/else
> branch.

Please don't do this.  Changing the argument list of an exported
function is an ABI break.  That's an OK change to do in branch master
(to keep the interface clean), but for released branches it is not
welcome, because it causes problems for users that have extensions that
call the function and were compiled with its older definition.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/