Date: Fri, 12 Jun 2026 01:59:06 +0300
From: Andrey Chernyy <andrey.cherny@tantorlabs.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: [PATCH] contrib/xml2: backend crash in xpath_nodeset() on the
 namespace axis
Message-ID: <20260612015906.38b47d04@andrnote>
In-Reply-To: <aioT7ui_ZJ9RMlfM@paquier.xyz>
References: <20260611031436.5afde3cb@andrnote>
	<aioT7ui_ZJ9RMlfM@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20260612015906.38b47d04%40andrnote>
Precedence: bulk

On Thu, 11 Jun 2026 10:48:30 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> What do you think?  That also deserves a backpatch to me, even if it
> is less worse than the xml2 crash you have reported.
> 
> I have grouped this fix with your patch in the attached.  Both still
> need some tests.  Each fix deserves its own commit, that's just a
> quick FYI version.

Thanks Michael, and thanks for adding the tests and back-patching! The
grouped patch looks good to me - applying the same XML_NAMESPACE_DECL
fallback to xmlXPathCastNodeToString() in core xml.c makes sense too. I
had a regression test in progress, but glad it's already covered.

--
Andrey Chernyy