From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Daniel Gustafsson <daniel@yesql.se>, Adrian Ho <ml+postgresql@03s.net>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17083: [PATCH] PostgreSQL fails to build with OpenLDAP 2.5.x
In-reply-to: <YOaxpoHOiO7Q41F2@paquier.xyz>
References: <17083-a19190d9591946a7@postgresql.org>
 <1666182.1625579201@sss.pgh.pa.us>
 <cc729116-2a2d-9edd-a32d-4066b92e4a75@03s.net>
 <1677203.1625582865@sss.pgh.pa.us>
 <e78eb1f9-57b1-dae9-39c8-5dd72268be89@03s.net>
 <1860066.1625677051@sss.pgh.pa.us>
 <68D22062-EC78-47C5-BC46-EF2F77193E19@yesql.se>
 <YOaxpoHOiO7Q41F2@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 08 Jul 2021 17:04:54 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2040196.1625774127.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 08 Jul 2021 15:55:27 -0400
Message-ID: <2040197.1625774127@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2040197.1625774127%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jul 08, 2021 at 09:53:11AM +0200, Daniel Gustafsson wrote:
>> Couldn't we add a version check to find if we have < 2.5 or >=3D 2.5, a=
nd adjust
>> libs accordingly?  Alternatively we could perhaps check for
>> LDAP_API_FEATURE_X_OPENLDAP_REENTRANT which IIUC when set defines -llda=
p to be
>> reentrant.

> Would you fetch the version number directly from the library?

Yeah, that all sounds kind of fragile.

On investigation it seems that libldap_r has been around basically
forever.  Even my second-oldest buildfarm animal prairiedog has got
it (indeed libldap.dylib and libldap_r.dylib are symlinks to
the same file on that platform ... hmm).  My oldest animal gaur
is irrelevant to this discussion, because we don't support
--enable-thread-safety on it in the first place.

That being the case, I think we might be okay just going with the
solution in Adrian's last patch, ie use libldap_r if it's there
and otherwise assume that libldap is thread-safe.  It looks
fairly unlikely that anyone will ever have an issue with that;
while if we complicate the configure probe, we might be introducing
new problems just from that.

			regards, tom lane