Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1epgBD-0007sM-Fj
	for pgsql-bugs@arkaria.postgresql.org; Sat, 24 Feb 2018 20:12:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1epgBC-0007rQ-7y
	for pgsql-bugs@arkaria.postgresql.org; Sat, 24 Feb 2018 20:12:22 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1epgBC-0007rG-2D
	for pgsql-bugs@lists.postgresql.org; Sat, 24 Feb 2018 20:12:22 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1epgB4-0007Yg-UH; Sat, 24 Feb 2018 20:12:21 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w1OKCAlK020440;
	Sat, 24 Feb 2018 15:12:10 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Meskes <meskes@postgresql.org>
cc: Andrew Gierth <andrew@tao11.riddles.org.uk>,
        jallen@americansavingslife.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT
In-reply-to: <20053.1519502594@sss.pgh.pa.us>
References: <151935568942.1461.14623890240535309745@wrigleys.postgresql.org>
 <1519483386.2654.291.camel@postgresql.org>
 <877er2nr8c.fsf@news-spur.riddles.org.uk>
 <1519501766.2510.13.camel@postgresql.org> <20053.1519502594@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sat, 24 Feb 2018 15:03:14 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20438.1519503130.1@sss.pgh.pa.us>
Date: Sat, 24 Feb 2018 15:12:10 -0500
Message-ID: <20439.1519503130@sss.pgh.pa.us>
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

I wrote:
> Michael Meskes <meskes@postgresql.org> writes:
>> Right, but it is missing in pg_config.h, too, right?

> No, it does get defined on Unix builds (if appropriate), both in
> pg_config.h and ecpg_config.h.

Oh, wait, now I see what you meant: there is no stanza like

#if (_MSC_VER > 1200)
#define HAVE_LONG_LONG_INT 1
#endif

in pg_config.h.win32.  I agree that there should be.  As I said, none
of the core backend cares at the moment ... but someday, that discrepancy
is going to bite us.

			regards, tom lane