From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
cc: Tender Wang <tndrwang@gmail.com>, Euler Taveira <euler@eulerto.com>,
        tharakan@gmail.com, pgsql-bugs@lists.postgresql.org,
        Heikki Linnakangas <hlinnaka@iki.fi>
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort
In-reply-to: 
 <CAMbWs49YbHiBZe-H3yOB0tN2FJDU5Y7Ed2VQ=G=iB_yqByHBkw@mail.gmail.com>
References: <18866-d68926d0f1c72d44@postgresql.org>
 <CAHewXNk6uX0VBROmoMrnKs_AOzbAQo+i9pouUiYj01y50HZRSw@mail.gmail.com>
 <1280897.1742920635@sss.pgh.pa.us>
 <CAHewXNm8rkn9Vu-WhmMQMJS2hSqztbJO1cRv5-+Rp99+k43aJw@mail.gmail.com>
 <b6ea023a-703d-4afa-8561-9e867db1b5f0@app.fastmail.com>
 <1618267.1743004859@sss.pgh.pa.us>
 <CAHewXNkND-jyFhxShh8Zf6ZNZ41V6skiAp_nwNrOBX25Gd02ig@mail.gmail.com>
 <CAMbWs49YbHiBZe-H3yOB0tN2FJDU5Y7Ed2VQ=G=iB_yqByHBkw@mail.gmail.com>
Comments: In-reply-to Richard Guo <guofenglinux@gmail.com>
	message dated "Thu, 27 Mar 2025 17:48:22 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2052346.1743091273.1@sss.pgh.pa.us>
Date: Thu, 27 Mar 2025 12:01:13 -0400
Message-ID: <2052347.1743091273@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2052347.1743091273%40sss.pgh.pa.us>
Precedence: bulk

Richard Guo <guofenglinux@gmail.com> writes:
> Not related to this issue but I wonder why blkno is verified after
> the relation is opened.  It can be verified beforehand, no?

It makes sense to me to check the parameters left-to-right, so
I think verifying blkno after relation is fine.  It's not like
there's value in optimizing the failure case.

This does, however, suggest that we ought to check the relkind
immediately after opening the rel, before the blkno check.
I'll adjust the patch that way and push.

			regards, tom lane