From: Tom Lane <tgl@sss.pgh.pa.us>
To: okano.naoki@jp.fujitsu.com
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17514: Application with embedded SQL crashes when executing
 EXEC SQL PREPARE
In-reply-to: <17514-edd4fad547c5692c@postgresql.org>
References: <17514-edd4fad547c5692c@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Thu, 09 Jun 2022 06:40:28 -0000"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <2059805.1654794010.0@sss.pgh.pa.us>
Date: Thu, 09 Jun 2022 13:01:36 -0400
Message-ID: <2060083.1654794096@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2060083.1654794096%40sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2059805.1654794010.1@sss.pgh.pa.us>

PG Bug reporting form <noreply@postgresql.org> writes:
> Application with embedded SQL crashes with segmentation fault if I execute
> EXEC SQL PREPARE
> command before executing EXEC SQL CONNECT command (*1).
> I know that it is the correct operation to execute EXEC SQL CONNECT command
> first 
> and then execute EXEC SQL PREPARE command.
> But I expect this wrong operation to result in an error, not a crash.

We could do something like the attached, perhaps.  Having said that,
an application that includes no error checks is pretty unlikely to
fail gracefully :-(.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="ensure-TSD-key-is-valid-before-use.patch";
	charset="us-ascii"
Content-ID: <2059805.1654794010.2@sss.pgh.pa.us>
Content-Description: ensure-TSD-key-is-valid-before-use.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/src/interfaces/ecpg/ecpglib/connect.c b/src/interfaces/ecpg/e=
cpglib/connect.c
index 8dfcabe3b5..90f2ba9701 100644
--- a/src/interfaces/ecpg/ecpglib/connect.c
+++ b/src/interfaces/ecpg/ecpglib/connect.c
@@ -40,6 +40,8 @@ ecpg_get_connection_nr(const char *connection_name)
 	if ((connection_name =3D=3D NULL) || (strcmp(connection_name, "CURRENT")=
 =3D=3D 0))
 	{
 #ifdef ENABLE_THREAD_SAFETY
+		ecpg_pthreads_init();	/* ensure actual_connection_key is valid */
+
 		ret =3D pthread_getspecific(actual_connection_key);
 =

 		/*
@@ -78,6 +78,8 @@ ecpg_get_connection(const char *connection_name)
 	if ((connection_name =3D=3D NULL) || (strcmp(connection_name, "CURRENT")=
 =3D=3D 0))
 	{
 #ifdef ENABLE_THREAD_SAFETY
+		ecpg_pthreads_init();	/* ensure actual_connection_key is valid */
+
 		ret =3D pthread_getspecific(actual_connection_key);
 =

 		/*

------- =_aaaaaaaaaa0--