Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j7pv5-0001sE-28 for pgsql-hackers@arkaria.postgresql.org; Sat, 29 Feb 2020 00:23:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j7pv3-0002Xy-GT for pgsql-hackers@arkaria.postgresql.org; Sat, 29 Feb 2020 00:23:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j7pv3-0002W5-7c for pgsql-hackers@lists.postgresql.org; Sat, 29 Feb 2020 00:23:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j7puw-0004j8-CE for pgsql-hackers@lists.postgresql.org; Sat, 29 Feb 2020 00:23:48 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 01T0Ncc8020706; Fri, 28 Feb 2020 19:23:38 -0500 From: Tom Lane To: Michael Paquier cc: Mahendra Singh Thalor , Robert Haas , Kyotaro Horiguchi , PostgreSQL Hackers Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema In-reply-to: <20200228232138.GI2688@paquier.xyz> References: <20200108004409.GA3413@paquier.xyz> <5602.1578444917@sss.pgh.pa.us> <20200108015601.GB3413@paquier.xyz> <20200109040612.GG2251@paquier.xyz> <20200110080125.GA250447@paquier.xyz> <20200110110748.GD250447@paquier.xyz> <20200116040618.GF3117@paquier.xyz> <18998.1582910402@sss.pgh.pa.us> <4172.1582915529@sss.pgh.pa.us> <20200228232138.GI2688@paquier.xyz> Comments: In-reply-to Michael Paquier message dated "Sat, 29 Feb 2020 08:21:38 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20704.1582935818.1@sss.pgh.pa.us> Date: Fri, 28 Feb 2020 19:23:38 -0500 Message-ID: <20705.1582935818@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Paquier writes: > On Fri, Feb 28, 2020 at 01:45:29PM -0500, Tom Lane wrote: >> After poking around, I see there aren't any other callers. But I think >> that the cause of this bug is clearly failure to think carefully about >> the different cases that isTempNamespaceInUse is recognizing, so that >> the right way to fix it is more like the attached. > Good idea, thanks. Your suggestion looks good to me. Will push that, thanks for looking. >> In the back branches, we could leave isTempNamespaceInUse() in place >> but unused, just in case somebody is calling it. I kind of doubt that >> anyone is, given the small usage in core, but maybe. > I doubt that there are any external callers, but I'd rather leave the > past API in place on back-branches. Agreed. regards, tom lane