From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
cc: Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
        sean.johnston@edgeintelligence.com,
        Postgres-Bugs <pgsql-bugs@postgresql.org>,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: [BUGS] BUG #14890: Error grouping by same column twice using FDW
In-reply-to: 
 <CAFjFpRc-QF+wHLJrsK2PeoKWXSG+u59qtjy6G5OvBp2G0adDSg@mail.gmail.com>
References: <20171107134948.1508.94783@wrigleys.postgresql.org>
 <10660.1510093781@sss.pgh.pa.us>
 <CAM2+6=X3CwoJ6LE3AGrDmBh1-zhJVd2WAPGKk0zLqDMfhJYOhQ@mail.gmail.com>
 <CAFjFpRf6A=G-x6TL0y01iRcjjz9A7=BUa4xdwZ0fbD13RsEnMg@mail.gmail.com>
 <9632.1510339476@sss.pgh.pa.us>
 <CAM2+6=Xmpptj19Vjk1H5gBo0grZNgqvjzRd-+ahfhyOaBJwPmQ@mail.gmail.com>
 <CAFjFpRc-QF+wHLJrsK2PeoKWXSG+u59qtjy6G5OvBp2G0adDSg@mail.gmail.com>
Comments: In-reply-to Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
	message dated "Tue, 21 Nov 2017 11:55:20 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20774.1515794117.1@sss.pgh.pa.us>
Date: Fri, 12 Jan 2018 16:55:17 -0500
Message-ID: <20775.1515794117@sss.pgh.pa.us>
Precedence: bulk

Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> writes:
> I am fine with the patch. It introduces a lot of expected output diff,
> since we always deparse GROUP BY clause in positional notation. That's
> fine. There is no point in adding extra logic to  use positional
> notation only when there are duplicate entries in the GROUP BY clause.

Yeah, agreed, particularly since that behavior has only been there since
10.0 anyway.  Pushed with a few cosmetic adjustments (mostly, improving
shaky English in the comments in foreign_grouping_ok()).

			regards, tom lane