From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
cc: Euler Taveira <euler.taveira@2ndquadrant.com>,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
        Maciek Sakrejda <m.sakrejda@gmail.com>
Subject: Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index
 names
In-reply-to: 
 <CAOBaU_aAXVAWjFeZvx7z7ctbZ0+ALuHee_PPm1yOeduhgGmnqw@mail.gmail.com>
References: <16502-57bd1c9f913ed1d1@postgresql.org>
 <CAH503wCS_XAQkFtH5xFeiL52tQpYc_qRbdFt3X-e8vfUP9pMdA@mail.gmail.com>
 <1816979.1592680000@sss.pgh.pa.us> <1845717.1592691069@sss.pgh.pa.us>
 <CAOBaU_YyjV1fHe_vz8TtfxdSKZFP0UZirCJwne279s0-4cRwuA@mail.gmail.com>
 <1882414.1592749757@sss.pgh.pa.us>
 <CAOBaU_aAXVAWjFeZvx7z7ctbZ0+ALuHee_PPm1yOeduhgGmnqw@mail.gmail.com>
Comments: In-reply-to Julien Rouhaud <rjuju123@gmail.com>
	message dated "Sun, 21 Jun 2020 20:16:53 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2078442.1592840980.1@sss.pgh.pa.us>
Date: Mon, 22 Jun 2020 11:49:40 -0400
Message-ID: <2078443.1592840980@sss.pgh.pa.us>
Precedence: bulk

Julien Rouhaud <rjuju123@gmail.com> writes:
> On Sun, Jun 21, 2020 at 4:29 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> 2. Text-format EXPLAIN output will grow double-quotes around the
>> hypothetical index names, which are not there at present (I believe,
>> but didn't test it).  This shouldn't bother human users particularly,
>> but conceivably it might break hypopg's regression tests?

> Yes, the patch is working as expected.  Before:
> ...
> All of the regression tests except the one I added when the fix for
> brin hypothetical indexes was applied are still working, as they're
> looking for patterns like "Index.*<\d+>${amname}_${relname}" in the
> textual explain output.  There are a few fixes not released yet, so
> I'll update the broken brin regression test and publish a release soon
> to make sure that the packages don't get broken when the new minor
> versions are released.

Doesn't sound too painful then.  I pushed the patch to all branches;
it should appear in 13beta2 this week, and in the August quarterly
updates.

			regards, tom lane